KeenSoftwareHouse / SpaceEngineers

2.93k stars 896 forks source link

Adding allowMultiple to the descriptor attribute #607

Open fat-rooster opened 3 years ago

fat-rooster commented 3 years ago

A little quality of life change for modders to make our code a little cleaner. The allowMultiple=false restriction to the myEntityComponentDescriptor attribute meant we needed to build duplicate classes for each builder we wanted to add logic to, rather than adding the same logic to multiple builders.

See this mod for the motivating example. (Ignore the lack of nuance to it. I'm just referring to the duplicated classes) https://steamcommunity.com/sharedfiles/filedetails/?id=2288648839

No functionality is lost or modified with this change. The code already retrieves the attribute as an array. The null check would require a bug in system.reflection to fail, so can probably be omitted too. Thanks for your time.