search

KeepJ96 / IP-Check

A Bukkit Plugin for Detecting and Controlling Multi-Accounters
BSD 3-Clause "New" or "Revised" License
1 stars 4 forks source link

Bungee Support #15

Open KeepJ96 opened 7 years ago

KeepJ96 commented 7 years ago

We need to add support for servers configured with Bungee. Testing needed to see if multiple instances of IP-Check can connect to the same MySQL server, or if the plugin needs to be configured as a Bungee Proxy plugin.

dutchy1001 commented 7 years ago

I can confirm that with a MySQL you can cross server check players even if they haven't been on the server were the command for a report is given.

KeepJ96 commented 7 years ago

So then if they're all pointed to one database and working, would that mean, if a player logged in on one server, you'd be able to pull up his info on any connected server (that has the plugin installed)?

If so, that would constitute basic Bungee support, would it not? I know you still wouldn't get login notifications and /ipc scan wouldn't work on a global level, but that would at least allow cross-check information to be shared between the server?

If that's the case, then we'd need to look into getting other functions working or testing functionality. If multiple copies of IPC can talk to the same database, then that would suggest that all the commands would work as well (from a database point of view.) We'd need to do testing to see how server actions (ie Bukkit.getPlayer("player").setBanned(true);) would propogate across those servers, since I have a feeling they wouldn't.

Most likely we'd still need to look at implementing the Bungee API.

dutchy1001 commented 7 years ago

Yes indeed this is a basic form of Bungee support. As you said the other commands should also integrate through the servers connected. In theorie all value's that are stored in a MySQL db should work on a global network. In this case the ban feature should work. (I cant check this as if I ban my alt it bans my IP (thus me) too). A system to ban alts but not the main account should be something to look into too (but that would be an other issue). The command /ipc scan would indeed need some work to check global, but I think that is 1 of the exception commands as this does not read from the DB but looks at the player list. With the command /ipc status it could have a new field of servers connected/excluded.

KeepJ96 commented 7 years ago

Does the regular /ban command propogate globally on Bungee servers, though?

dutchy1001 commented 7 years ago

Depending on the ban plugin you use. The plugin I use , AdvancedBan, when added to the bungeecord server it does ban global, but when added to a single server in the within bungee setup it only bans per server.

KeepJ96 commented 7 years ago

Okay. I'll have a look then at how that works. See if it's something we can implement into IPC.