To reduce ambiguity, we would want to report unscannable files whenever we're querying for getSupportedABIs(). This is done by:
Employing an object which could store problematic Files information in addition to the supported ABIs.
Modifying getSupportedABIs()'s catch clause to capture said information.
Modifying MissingLibraryException to report it.
Additionally, to ease testing, refactor ZipFile factory logic out from ApkLibraryInstaller so we can mock this scenario.
Sample exception message post this change
Could not find 'libtest.so'. Looked for: [armeabi-v7a], but only found: []. Additionally, encountered errors while scanning: [fake.apk => java.io.IOException: Could not create zip file.].
What has changed
To reduce ambiguity, we would want to report unscannable files whenever we're querying for
getSupportedABIs(). This is done by:Files information in addition to the supported ABIs.getSupportedABIs()'s catch clause to capture said information.MissingLibraryExceptionto report it.Additionally, to ease testing, refactor
ZipFilefactory logic out fromApkLibraryInstallerso we can mock this scenario.Sample exception message post this change
Why it was changed
As an attempt to resolve #107.