Please clarify in documentation, whether ReLinker is only useful for certain API levels

KeepSafe / ReLinker

A robust native library loader for Android.

Apache License 2.0

3.23k stars 371 forks source link

Please clarify in documentation, whether ReLinker is only useful for certain API levels #64

Closed marcardar closed 4 years ago

marcardar commented 5 years ago

In more recent versions of Android (since 23) we have extractNativeLibs option in the application element of the Android Manifest file. Is ReLinker still beneficial when setting this flag to false?

Also, what specific issues (maybe point to some issues in the Android issuetracker) are solved by this library?

chrisjenx commented 5 years ago

We were just wondering this, is this still needed on newer devices. (We are 21+)

benjamin-bader commented 5 years ago

It's not 100% clear that the package-manager bugs were fixed as of 21, but for 23+ I believe ReLinker is no longer necessary.

@chrisjenx the only real way to know for your case would be to ship without relinked, and just watch for UnsatisfiedLinkErrors. Or, to be safe, just use it and remember to tear it out when you bump your min SDK to 23.

hborders commented 4 years ago

Consider updating the javadoc in ReLinker.java to mention this.