search

KeepSafe / TapTargetView

An implementation of tap targets from the Material Design guidelines for feature discovery.
Apache License 2.0
5.39k stars 591 forks source link

Xfer mode change in Android P #313

Closed hearsilent closed 6 years ago

hearsilent commented 6 years ago

Version used: 1.12.0

Stack trace: In support library 28.0.0, start of anim will have a rect.

27.1.1

28.0.0

Android version: 9.0

xiphirx commented 6 years ago

Does this still occur after the Android X migration that was just committed? I'm confused as to why the support library would change how the Canvas operates... Are you sure this isnt an Android P issue?

hearsilent commented 6 years ago

@xiphirx You can see this issue: https://issuetracker.google.com/issues/111819103 Google says won't fix :'(

hearsilent commented 6 years ago

@xiphirx Yep, still occur in AndroidX. I'll fix conflicts and notice you 💯

xiphirx commented 6 years ago

Ok yeah, this isn't because of the support library / Android X, but because of Android P... I'll have to understand the change more to figure out the appropriate solution. I'm not sure adding more Paths is the best way for efficiency concerns.

hearsilent commented 6 years ago

In pre 19 devices method is so tricky. I use clipPath but circle is jagged, so need to draw a 1px border circle to fix jagged.

You can see this method in uCrop.

Note: clipPath doesn't like drawCircle can use paint with anti alias.