Keeper-Security / Commander

Keeper Commander is a python-based CLI and SDK interface to the Keeper Security platform. Provides administrative controls, reporting, import/export and vault management.
https://www.keepersecurity.com/commander.html
MIT License
182 stars 74 forks source link

Typo "Sharable" instead of "Shareable" #1234

Closed Silentapproach closed 1 month ago

Silentapproach commented 2 months ago

Error Shareable When running the command ShareRecordCommand.execute on a record that is already shared to the user that it should be shared with again, an error occurs.

The error states that there is no such key as "sharable" because the correct key name is "shareable".

Error:

keepercommander\commands\register.py", line 884, in execute ro.shareable = True if can_share else current['sharable']


KeyError: 'sharable'

When I searched through the whole project I found more than two results (the ones addressed in this pr). 
I didn't want to touch them because I only worked with ShareRecordCommand out of the ones that contain "sharable"
aaunario-keeper commented 1 month ago

Closing this PR, as this issue has been addressed in release v16.10.14 (available here)