Keeper-Security / terraform-provider-secretsmanager

MIT License
8 stars 4 forks source link

Feature Request - Manage Folders/Shared Folders #10

Open CSimpiFoN opened 2 years ago

CSimpiFoN commented 2 years ago

Please add the functionality to manage folders and shared folders with Terraform (Creating/Deleting/Sharing)

Or at least add 'folder' data source, so the UID won't need to be checked and added manually to every single secret.

ladams-keeper commented 2 years ago

Hello, Could you please describe what you are hoping to achieve with the Terraform Secrets Manager integration in this case?

When you say "add 'folder' data source, so the UID won't need to be checked and added manually to every single secret." Do you mean the folder UID which is required when creating new secrets, or something else?

heretic098 commented 1 year ago

Again, while I'm here. At the moment my workflow to use the keeper terraform provider goes like this:

  1. Create a shared folder in the main Keeper web vault screen
  2. Use the ksm cli to get the shared folder's uid
  3. Hard code that uid into a variable in terraform
  4. Create secretsmanager resources using that shared folder uid which I get from my terraform variable

What I would rather do is:

  1. Use the new keeper secretsmanager_shared_folder resource to create my shared folder
  2. Pass the shared folder uid to other keeper secretsmanager* resources using a terraform output, e.g. below

folder_uid = secretsmanager_shared_folder.my_folder.uid

Or at the very least, have a data_source that lets me pick up the folder UID based on the name of the folder so that I can pass that to other secretsmanager resources. I'm assuming my problem is representative of what @CSimpiFoN is asking.

ppodevlabs commented 1 year ago

this would be really helpful for us to manage shared folders within teams, etc

maksimu commented 1 year ago

Filed internally as KSM-390

rdavisunr commented 1 year ago

Filed internally as KSM-390

@maksimu - what was the outcome of this internal issue?

My company is a Keeper customer and we are currently evaluating Secrets Manager as a potential addition.

In the prototype I am developing, it would be very useful to have a data source that could return a Shared Folder UID based on a Folder Name.

I'd also vote for Shared Folder creation/management, but I assume there are complexities due to the relationship between Shared Folders and Applications (like Terraform itself).

ericrichtert commented 11 months ago

Any update on this?

ghost commented 11 months ago

We need this feature as well, please Without managing folders, the keeper provider is not feature complete (i.e. we cannot create a full tree of folders/secrets using terraform). We'd have to do some things manually, and some automated with terraform, which is less than ideal..

ilsaloving commented 6 months ago

This issue isn't even specific to terraform. It looks like none of the integrations have the ability to enumerate shared folders. How did it not occur to anyone that such functionality would be critical?

ghost commented 6 months ago

Hi, is there an update on this, please?

craiglurey commented 6 months ago

This is currently in development. Ivan will reply on this thread when the update is completed. We appreciate your feedback and this is a top priority for the KSM team.

On Thu, Apr 25, 2024 at 6:27 AM mariusmanea-selfridges < @.***> wrote:

Hi, is there an update on this, please?

— Reply to this email directly, view it on GitHub https://github.com/Keeper-Security/terraform-provider-secretsmanager/issues/10#issuecomment-2077180372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQXAECG7VIRDLGH4NWMZ5TY7EAFDAVCNFSM6AAAAAARXC3IDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXGE4DAMZXGI . You are receiving this because you are subscribed to this thread.Message ID: <Keeper-Security/terraform-provider-secretsmanager/issues/10/2077180372@ github.com>