Add permissions entries for gates

Keesaco / KeesaFlo

A cloud-based flow cytometry web application

Other

6 stars 0 forks source link

Add permissions entries for gates #131

Closed McCrea closed 10 years ago

McCrea commented 10 years ago

Life is good.

Fixes in this pull request:

Fix file size badge spacing
Add permissions entries to gates
Only show files for current user
permissions checking in some data sources
redirection of unauthenticated requests to landing page

RoganMurley commented 10 years ago

Looks as good as life to me.

McCrea commented 10 years ago

With the current state of Bristol CS, I can't tell if that's a good thing or not.

McCrea commented 10 years ago

I've updated this so that you now only see files you have permissions for. Exciting or what? (Also please review.)

McCrea commented 10 years ago

Now implements authentication checking in all HTML/JSON views. (Still requires some attention in the file/image views as these need HTTP response codes rather than JSON.

RoganMurley commented 10 years ago

Looks excellent.

RoganMurley commented 10 years ago

Looking further at this I can't help but feel it's extended past being simply permissions and is now similar to the metadata database we planned to have. I think this is a good thing, but perhaps a rename is in order?

McCrea commented 10 years ago

I agree about the name; I had in fact discussed renaming it with a couple of people. The problem is time and time only. Whilst a more sensible name would be good, we have a number of open issues which I feel need to take priority.

hazeld commented 10 years ago

This looks good to me.