search

Keesaco / KeesaFlo

A cloud-based flow cytometry web application
Other
6 stars 0 forks source link

New file names. #133

Closed RoganMurley closed 10 years ago

RoganMurley commented 10 years ago

Fixes #101 by generating unique filenames for cloud storage and automatically using friendly filenames. Unfortunately the MD5 + timestamp idea for names could not be implemented due to the Datastore API not yet implementing a move function. Instead I have just used Python's UUID library.

McCrea commented 10 years ago

To my knowledge the underlying GCS library doesn't support moving files. It could be done at API level but would just be reading a file into a buffer, deleting it, then writing the buffer to the new location.

RoganMurley commented 10 years ago

I think the current fix is suitable.

McCrea commented 10 years ago

Good stuff.

hazeld commented 10 years ago

Other than my question above, everything looks great.

McCrea commented 10 years ago

Looks good to me. Fixes a number of issues so will merge shortly.

RoganMurley commented 10 years ago

Only notable issue remaining is loading the graph through the spinner after uploading. I just can't seem to get anywhere with it, could someone else take a look at that?