Closed hazeld closed 10 years ago
Looks good to me. Different glyphicons for the the new tools would be nice; we're unlikely to find anything which matches the functions performed particularly well, but something different would be good. The addition of new tools, to me, highlights issues with the usability of gating; perhaps some sort of dynamic instructions below the buttons would be of use.
Looks good, I feel visualise.py has outgrown itself though. I feel it would be a lot more readable if we moved each elif block into a different function. It's not that important but I think it'll probably be one of the first bits of code the marking panel looks at.
I agree with that. A dictionary mapping strings to methods might be useful here.
Agree with all three of those things. I'll re-factor visualise.py now. I have found icons that would be relatively suitable for the tools on mordernuiicons: centerline, greek.sigma.lowercase, measure.kilometer and vector.group.removed for boolean gating when that's done. But I have no idea how to add them. We also definitely need to add instructions for the tools at some point.
I'll add the tool icons to the webfont later (probably today). As for the instructions, a tour or anything fancy might be more than we have time for at this stage. (Unless anyone wishes to volunteer?) My solution would be a well below the buttons or graph which would display help text. Normally it would display a sort of 'on screen walkthrough': "Select a tool from the selector on the left to begin gating." But would probably be overwritten by a sort of extended tooltip on hovering over certain things.
Ok, I've neatened visualise.py, better?
Yeah looks a lot better. Should we perhaps keep the new functions in a different file and import them? It doesn't really matter but might be nice.
I think it's a lot neater. It'd be good to get this onto development soon so that everyone can try it out and make sure nothing breaks. I'm going to merge this shortly. Naturally moving things into new files etc. can still happen.
In this pull request:
It's live here: http://hazel.keesaco-spe.appspot.com/ in case you want to see the gates.