search

Keesaco / KeesaFlo

A cloud-based flow cytometry web application
Other
6 stars 0 forks source link

Undo button #141

Closed McCrea closed 10 years ago

McCrea commented 10 years ago

Adds an undo button. Graphically it's pretty crude, but it successfully goes back to the parent graph.

RoganMurley commented 10 years ago

Looks good, but currently the 'undo' tooltip stays when you have navigated back to the parent graph and the undo button has disappeared.

McCrea commented 10 years ago

Hey, I said it ease crude, didn’t I? On 24 Apr 2014, at 08:40, Purpwood notifications@github.com wrote:

Looks good, but currently the 'undo' tooltip stays when you have navigated back to the parent graph and the undo button has disappeared.

— Reply to this email directly or view it on GitHub.

McCrea commented 10 years ago

I’ll see if I can add something to the delegation which catches elements being removed and destroys the tooltips too. On 24 Apr 2014, at 08:40, Purpwood notifications@github.com wrote:

Looks good, but currently the 'undo' tooltip stays when you have navigated back to the parent graph and the undo button has disappeared.

— Reply to this email directly or view it on GitHub.

RoganMurley commented 10 years ago

I'm confused... but yeah other than that looks good :+1:

McCrea commented 10 years ago

My latest commit (069525b) should resolve the persistent tooltip and all manifestations of the same problem.

mrudelle commented 10 years ago

Shouldn't a undo delete the current gate before going back to the previous one?

McCrea commented 10 years ago

That's really one for user testing... A bit late for that now. The general view here is that we shouldn't delete the file as long as there's a delete button. It's really more of a 'back' button.