search

Keesaco / KeesaFlo

A cloud-based flow cytometry web application
Other
6 stars 0 forks source link

Boolean Gating Tool #146

Closed hazeld closed 10 years ago

hazeld commented 10 years ago

A relatively rough (in graphTools.js) implementation of Boolean Gating.

This is a simplified version of what the server side can do, i.e. the gating works only on the current graph axes and only with the polygon tool (as Andrew said this was the most used), whereas on server side you can use any combination of the three basic gates and can specify the gate regions to be on different axes from one another. Implementing full Boolean Gating would probably either take too long or seriously impact the ease of use of the gating tools and I feel the report needs a lot of attention.

Due to the simplifications only 'or' gates are implemented as 'and' gates would be the same as just selecting the region desired due to both polygon gates being on the same axes.

Again this is up on my version if you'd like to look.

RoganMurley commented 10 years ago

Looks good to me.

McCrea commented 10 years ago

Will do a full review shortly when I have time. You can use 'vector-glyph-vector-group-removed' for the boolean gating symbol. (See #144)

mrudelle commented 10 years ago

The Javascript and python looks good to me. Though a 2D array could have been used to simplify the code but due to time pressure this is not important.