search

Keesaco / KeesaFlo

A cloud-based flow cytometry web application
Other
6 stars 0 forks source link

Add gating info #151

Closed mrudelle closed 10 years ago

mrudelle commented 10 years ago

This concern only cell count for now but might be extended

mrudelle commented 10 years ago

There is still a pb when we view a "root" gate but it can be fixed by creating a dummy gate file info when a file is uploaded (Could you add this Hazel?)

hazeld commented 10 years ago

Yep, going to work on that this afternoon.

McCrea commented 10 years ago

Why does this need to be loaded asynchronously? The file_preview pagelet is requested each time the current file changes, is gated, or finishes analysis after upload. The information could be inserted straight into the file_preview teplate by the server side and it'd be done in a few lines.

mrudelle commented 10 years ago

I presume it's the same reason the graph is downloaded asynchronously. Actually I started to implement it on the server and changed after seeing it was not working but I cannot remember why...

McCrea commented 10 years ago

The graph polls asynchronously but then it just redirects to the new file rather than trying to re-write the page for the old file. There's no need to request this on page load, it can just be put there statically. It might be worth putting a condition on the gating status returning that the gate is done so that it only redirects one the image AND the information exist (currently it only checks for the image file being present).

mrudelle commented 10 years ago

My bad, I see what you mean, I will make the changes.

mrudelle commented 10 years ago

Changes are now done. Ready for review, a working version is available at matt.keesaco-spe.appspot.com as usual.

McCrea commented 10 years ago

The percentage seems to be out by a factor of 100. Other than that it looks good to me. I'm not sure if the text might be a little wide when shown on a mobile device, but I think it's okay for now.

Finally, this seems to be based on an old version of development, could you pull development and then push again?

mrudelle commented 10 years ago

All ready and tidy.

McCrea commented 10 years ago

Excellent. Looks good to me. Will merge shortly.