search

Keesaco / KeesaFlo

A cloud-based flow cytometry web application
Other
6 stars 0 forks source link

Fixes #85 - add delete button #89

Closed McCrea closed 10 years ago

McCrea commented 10 years ago

Adds a delete button to the file selector. See #85. Note that the position of the delete button will be changed in a later commit when other file actions are implemented.

hazeld commented 10 years ago

This looks good. The only issue I can think of is what happens when the file is deleted? Does the page still display the graph of the deleted file and therefore allow you to attempt to gate it before you refresh?

McCrea commented 10 years ago

Currently it won't redirect the user and it would allow them to gate a non-existent file. I'm aware of this and will be implementing a fix soon alongside a number of other fixes/enhancements. However, it's important that the server-side be able to deal with requests to gate non-existent files since anyone can create requests to gate arbitrary files as the request is made by the client side.

This pull request doesn't represent a finished addition, but since it's been noted a few times that it would be useful to be able to delete files without having to manually clear the datastore and file store, I put it up anyway in case anyone wanted it.

hazeld commented 10 years ago

This looks good.