Home screen taps get swapped

Kegbot / kegbot-android

Android beer kegerator frontend and controller app. Works with a Kegbot server to make your kegerator awesome.

http://kegbot.org/docs/android/

GNU General Public License v2.0

41 stars 53 forks source link

Home screen taps get swapped #91

Closed mik3y closed 10 years ago

mik3y commented 10 years ago

Sometimes the home screen shows the wrong taps, for example a hidden tap instead of a visible one.

I've traced it down to Fragment[State]PagerAdapter. As taps come and go, they get reordered. We call notifyDataSetChanged() and return POSITION_NONE for all fragments, which should be sufficient, however I've seen that in many cases this does not call getItemPosition() for the on-screen views, resulting in the inconsistency.

Looks like the upstream issue is http://b.android.com/37990

mik3y commented 10 years ago

Fixed in 2ec6489f4fd1472fb6718fa2bd119e2a03c6c7fc.