search

Kegbot / kegbot-android

Android beer kegerator frontend and controller app. Works with a Kegbot server to make your kegerator awesome.
http://kegbot.org/docs/android/
GNU General Public License v2.0
42 stars 53 forks source link

Updated README and enabled Proguard code shrinking #96

Closed LukeAllen closed 9 years ago

LukeAllen commented 10 years ago

Changed README to give the correct setup instructions for Android Studio, including fixes for some current glitches in Android Studio. (I spent a few very frustrating hours trying to import into Eclipse as recommended by the current instructions!)

Configured proguard to shrink the code, and enabled proguard in both debug and release mode. The project was failing to run because of the Dalvik method limit as discussed here: http://stackoverflow.com/questions/15209831/unable-to-execute-dex-method-id-not-in-0-0xffff-65536

Apparently the measurements library used in Units.java has changed, so I did a minor syntax fix there. (I'm not sure what all the .xml file changes are; I'm guessing they're automated stuff? I've mostly coded in Eclipse and not Android Studio.)

LukeAllen commented 10 years ago

Actually allowing shrinking seems to have broken later parts of the app. Troubleshooting it now.

LukeAllen commented 10 years ago

On further investigation, I don't think it's a Proguard issue; disabling shrinking doesn't change it. The two problems I'm seeing are this, with com.google.common, in debug mode: http://stackoverflow.com/questions/16608135/android-studio-add-jar-as-library

and this, in release mode: http://stackoverflow.com/questions/16932248/crashlytics-could-not-be-initialized-api-key-missing-from-androidmanifest-xml

Is your current code working properly for you, or are these problems in it also?

mik3y commented 9 years ago

Sorry for neglecting this change :(

I think #104 has covered similar ground. Please open a new PR if there's something more to it -- I'll try not to sit on it for so long :see_no_evil: