search

Kehom / GodotAddonPack

A collection of pure GDScript addons for Godot
http://kehomsforge.com
MIT License
183 stars 15 forks source link

[Network] player_removed is not called for clients #18

Closed yuraj11 closed 3 years ago

yuraj11 commented 3 years ago

player_added signal works fine and it's called on all clients but player_removed is called only on server.

fairhat commented 3 years ago

@yuraj11 are you using websockets and testing on smartphone browsers?

I noticed that websockets on iOS Safari aren't properl closed if the user leaves the website. Sometimes it takes up to 10 mins for godot to notice that the player has left.

yuraj11 commented 3 years ago

On desktop but there's implementation but it is commented in network.gd in function _on_player_disconnected for some reason.

Kehom commented 3 years ago

Is this still the case? I ask because 6192200976d9f4e8471a60a03cd4c0966d2b731c has changed the _on_player_disconnected and there is no commented "command" in it since that commit.

yuraj11 commented 3 years ago

Yeah sorry didn't see it. Works :)