Keinta15 / Magisk-iOS-Emoji

Systemlessly replaces emoji font with iOS Emoji
143 stars 13 forks source link

new release 17.4 #32

Closed liukliukliuk closed 1 week ago

liukliukliuk commented 2 months ago

hi, thanks again for your work. could you please update the emojis with 17.4 release? thanks

bugreportion commented 3 weeks ago

could you please update the emojis with 17.4 release?

You can use my own fork. There is an updated version.

dtingley11 commented 3 weeks ago

could you please update the emojis with 17.4 release?

You can use my own fork. There is an updated version.

@bugreportion hello sir! I used your fork on ksu (overlayfs) the only problem is that it causes my apps to be detected (momo detects magisk somehow?!) and Microsoft intune company portal also detects root so I cannot use it :( However, I used this other module that replaces fonts and does not need huskydg's overlayfs module: (https://github.com/WSTxda/Mi-Lan-Font-Module) I believe that if you remade the module to be more like this it would work with kernelsu. Is that a possibility?

bugreportion commented 2 weeks ago

@dtingley11 Oops, I just saw your comment, sorry for the delay.

module that replaces fonts and does not need huskydg's overlayfs module

In that case use attached regular version without overlayfs prefix.

There's additional workaround for HuskyDG's overlayfs module specific for KernelSU, it might help you. Momo will detect abnormally mounted partition until you change fs mode to read-only locked.

dtingley11 commented 2 weeks ago

@dtingley11 Oops, I just saw your comment, sorry for the delay.

module that replaces fonts and does not need huskydg's overlayfs module

In that case use attached regular version without overlayfs prefix.

There's additional workaround for HuskyDG's overlayfs module specific for KernelSU, it might help you. Momo will detect abnormally mounted partition until you change fs mode to read-only locked.

@bugreportion Thanks for the follow up. I used the regular version without overlayfs and that one just doesn't work. I was able to fork the original repository and fix some of the code myself so that it would work with kernelsu. Maybe you could take a look and add those changes in your repo so we don't need mine, as my code is a little janky 😂

bugreportion commented 1 week ago

@dtingley11 Hey, not sure you even need this now, however my fork got update. I've tested emoji module working, including replacing of emoji for FB/Messenger on my devices with KernelSU. So yours should be fine too now.

dtingley11 commented 1 week ago

@dtingley11 Hey, not sure you even need this now, however my fork got update. I've tested emoji module working, including replacing of emoji for FB/Messenger on my devices with KernelSU. So yours should be fine too now.

@bugreportion Thanks for the update! I'll install this when I get home. I'm still new to creating modules, so I borrowed code from your fork and the original. I'll probably just use yours from now on 🙂

Keinta15 commented 1 week ago

@dtingley11 Hey, not sure you even need this now, however my fork got update. I've tested emoji module working, including replacing of emoji for FB/Messenger on my devices with KernelSU. So yours should be fine too now.

@bugreportion Do you mind if I take a look at your fork to verify how to add support to KSU? (Currently don't have a device with KernelSU to test on). Of course will add credit, the changes you guys have made look pretty good

bugreportion commented 1 week ago

No problem.

Keinta15 commented 1 week ago

Perfect, will be closing down this issue since the original issue got resolved.

dtingley11 commented 1 week ago

@Keinta15 sounds good. Thanks!