Open Donach opened 3 months ago
[!WARNING]
Rate limit exceeded
@Donach has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 58 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between c9cb50d258ad2c1cccef0038ea951d5406792229 and 4cc9dcb516802b223aac5cd1b3f5fedf66211c54.
The recent changes enhance the functionality of commit message retrieval and processing in the src/git.rs
file. Adjustments to the read
and extract_commit_messages
functions improve the format and quality of commit messages extracted from the git log. By including additional commit details and refining message parsing rules, the updates ensure better handling and representation of commit information.
File | Change Summary |
---|---|
src/git.rs |
Updated read function to use a more detailed git log format. Modified extract_commit_messages to improve message splitting and prevent empty messages. Adjusted parse_commit_message conditions for footer recognition. |
In the world of commits, so bright and grand,
A rabbit hops swiftly, with changes so planned.
With messages clearer, and formats so neat,
Our git logs are tidy, a marvelous feat!
So let’s dance with joy, in the digital air,
For every new commit, with love and with care! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Sorry for the delay, thank you for your PR! We need some unit tests for it!
I'll try to take a look within the next few weeks if there are some sensible tests to be added...
Why
I've tested the tool and decided to implement it in our company. However, there are some logical flaws which prevent us from using it. We have a policy that if a commit change is small enough, there is no need to fill in the body - the tool itself also allows to set for empty body of commit message.
However parsing of git commits with no body message creates problems. At the same time, it seems like the tool doesn't even properly split the messages, since when you use "--pretty=%B", it will return only subject+body of the commit message, so the
fn extract_commit_messages
will not work to separate commits properly.By applying this fix, I was able to fix this major flaw, it also breaks no tests and no other changes are necessary.
One minor bug -> if somebody would "abuse" my usage of "|" as artificial separator, it might break the logic a bit, but IMO that is very rare case to happen.
I'm open for discussion on how to improve it further, as we don't wanna overhaul the whole tool just to fit our "few special needs".
Summary by CodeRabbit
New Features
Bug Fixes