KeitaNakamura / neodark.vim

A dark color scheme for vim
410 stars 34 forks source link

Update Airline Theme #8

Closed TheBabu closed 7 years ago

TheBabu commented 7 years ago

Hello there! I was wondering if you could update your Airline theme, because I cannot figure out anything that going is on in your Airline theme even after reading the wiki a whole bunch of times...

screenshot_2017-05-02_20-40-23

Thanks! P.S.I really like your neodark themes!

KeitaNakamura commented 7 years ago

Hi!

I'm using lightline (not airline) actually. For airline, you would get following theme without any setting (you can see minimal vimrc in picture).

screen shot 2017-05-04 at 3 14 23

If you prefer the theme in README rather than above theme, try this:

screen shot 2017-05-04 at 3 20 34
TheBabu commented 7 years ago

Hmmm I think the problem that I have is that I have not installed your theme using your plugin, I'll try install it! Thank you for the reply! EDIT: Ah I think I know why your theme does not look my theme! After rereading the actual vim colors that you have, it has it so that when the background is transparent it changes the colors! I'll do a little hack to that!

Second Edit: After some tinkering around, I am wondering how to make the z section color in airline on to the very bright a little bit brighter? If you could help me out with, that would be much appreciated!

Third Edit: After tinkering A LOT with my that file, I have a deeper understanding on vim scripting... and know how to correctly change the colors know... So I have changed the colors to something I wanted! Closing this thread!

KeitaNakamura commented 7 years ago

Oh, sorry, I haven't noticed your message. I couldn't get any notification when you just edit your comment.

TheBabu commented 7 years ago

Ahaha I actually think it was better that you didn't reply because now, I know how to program vim scripts! :P

KeitaNakamura commented 7 years ago

I checked the theme when the background is transparent, and realized that all colors are brighter than default. Could you fix this problem?

TheBabu commented 7 years ago

I thought you made it when you are have a transparent background the colors change?

" Transparent Background
if g:neodark#terminal_transparent == 1
  let s:base1[1] = 'none' " This doesn't work well for airline
end

Or am I interpreting this code wrong?

KeitaNakamura commented 7 years ago

It's not ideal that the colors (blue, red, green, etc.) become brighter in the transparent background case. In my code, base1 is mostly used for background color, so I changed it to none for transparent case. But as you said,

After rereading the actual vim colors that you have, it has it so that when the background is transparent it changes the colors!

other colors also change. I have no idea to make background transparent in a correct way.

TheBabu commented 7 years ago

Hmmm.... maybe try doing set termguicolors, I have seen multiple vim scripts use this, and I think that is the reason why.

KeitaNakamura commented 7 years ago

It couldn't be help. I thought that you also had same problem. Thanks, anyway!

TheBabu commented 7 years ago

Haha... No need, I didn't really help you in the first place... :P