search

KejPi / AbracaDABra

Abraca DAB radio: DAB/DAB+ Software Defined Radio (SDR)
MIT License
67 stars 8 forks source link

Update German with EPG/SPI texts #120

Closed andimik closed 9 months ago

andimik commented 9 months ago

The only English text which is a bit strange is:

Hint: in Expert mode, the window is too small for the description below.

grafik

And some tool tips are quite wide (maybe a <br> helps here?)

grafik

andimik commented 9 months ago

And there are still English texts (although my OS is German).

No file selected grafik

Copy and Select all

grafik

KejPi commented 9 months ago

Thanks for the translation. Let me comment your notes: 1) I agree, overwrite checkbox tooltip is strange, I will change that (new translation will be needed ;-) ) 2) The dialog adopts its size on opening in expert mode. Only when you open dialog in basic mode and enable expert, it does not adjust the size. I know about this issue, I will try to fix it. 3) I agree tooltip is long - I will change that 4) "No file selected" - I can confirm the issue. It is strange, the string is marked for translation but ii does not appear in translation source. I will check that. 5) Popup menu is Qt stuff - application does not define the strings. This happens on all 3 OS's I will have to as Google how to fix it.

KejPi commented 9 months ago

I have (hopefully) fixed 1, 3, 4 - I do not know how to fix 5 and attempts to fix 2 are even worse - so I leave these issues for some next version, I think they are minor. There are few new strings, could you please translate them? Thanks!

andimik commented 9 months ago

Can you please explain what is the directoryID? Seems this value changes each day, as for the same EId I had 3 different folders (with all SPI, all same pngs and the - updated - xml files)

KejPi commented 9 months ago

Yes, that is correct behavior. Directory ID is transport ID of directory object (directory object is a description of items in carousel). It shall change anytime content of directory changes so it would be probably at least once a day. It is clear? If yes, I would add this description to README.

EDIT: do you think it would be more clear if is change description of {directoryID} in the application to "transport ID of directory" (update of translation file would be required :-( )

andimik commented 9 months ago

Yes, that explains it :-)

"transport ID of directory"

In such a case the German translation would be "Transport ID des Ordners". You may update it as well ...

KejPi commented 9 months ago

Perfect, thanks, I would like to make release tonight so that I have weekend for fixing reported bugs ;-)

andimik commented 9 months ago

Regarding SPI: I have a binary file with extension xml and an xml with extension xml.xml. Is this intended?

andimik commented 9 months ago

0_10450.zip

KejPi commented 9 months ago

It depends. If they transmit object with content name with xml extension then it is correct. What do you see in the log?

andimik commented 9 months ago 
00:46:09.242 [I] SPIApp: Storing file: "/tmp/SPI/e49400/0_58317/si.xml"
00:46:09.245 [I] SPIApp: Storing file: "/tmp/SPI/e49400/0_58317/si.xml.xml"

So this is coming from the broadcaster?

KejPi commented 9 months ago

It looks correct - all other files are stored as expected and SI.xml should be handled the same way.

andimik commented 9 months ago

But I thought the xml was parsed by AbracaDABra in order to get the xml.xml

KejPi commented 9 months ago

Yes, it was parsed. You would need to enable debug messages in spiapp.cpp to see what objects are in carousel. I could add this to application log but i ma not sure if it has any values for user - it is more for debug purposes.

EDIT: SI.xml comes from broadcaster, application decodes it and stores it as SI.xml.xml

andimik commented 9 months ago

another question (before I check the debug messages)

The line 

19:12:35.374 [I] SPIApp: 0: MOT directory NOT complete (decoded 9 / 60)

is the first one, there is no line for 1 / 60 till 8 / 60 ...

KejPi commented 9 months ago

Yes, it is possible - MOT directory is one of the objects, it is transmitted periodically (frequency depends on broadcaster). In this case there were already 9 objects received when directory was received. In theory if directory is received as very last you would see 60/60 only message.

andimik commented 9 months ago

oh, I though this counter says, how many files have been received ...

KejPi commented 9 months ago

it does, but it can start when directory is received because before application does not know what objects belong to current directory.