search

KejPi / AbracaDABra

Abraca DAB radio: DAB/DAB+ Software Defined Radio (SDR)
MIT License
68 stars 8 forks source link

Transparent PNG background color #144

Closed andimik closed 1 month ago

andimik commented 4 months ago

Do you have an idea how to prevent this behavior with transparent PNG files in SPI?

Bildschirmfoto vom 2024-07-02 23-36-33 e0_ad68_320x240_3 e0_ad68_128x128_2 e0_ad68_112x32_1 e0_ad68_32x32_0

When SLS has been received, then the file is a JPG. Bildschirmfoto vom 2024-07-02 23-37-18

sls1_6

KejPi commented 4 months ago

Well, it is black because all slides have black background that is not visible for non-transparent images but it appears when image is smaller or if it has transparency. I was looking for some guidelines in documentation from WorldDAB and I have not found any recommendation what to do with transparent logos. When I was implementing it, my assumption was that typical car radio has a black screen and dark UI. So I would assume broadcasters should provide their media assets in the format that looks good in car because it is the majority of radio listening. The other assumption that shall be considered is that in dark mode the image background should be dark too. To be honest, I do not have any reference how the manufacturers are implementing station logos visualization for DAB, if you have any, please share.

andimik commented 4 months ago

But the smaller file (top left) is visible, although it is transparent (see files below), too!

So you should use the same background color in the SLS window.

KejPi commented 4 months ago

Yes, it is visible because I do not set any background there, but try how visible it is in dark mode.

Snímek obrazovky 2024-07-03 v 19 50 12
KejPi commented 4 months ago

This is probably the best compromise. By the way - you can see how stupid they are :-D This is clearly problem on their side, if they want to have white background they should set it in the logo or make the logo in the way that looks good on any background color in gray scale.

Snímek obrazovky 2024-07-04 v 20 53 10
andimik commented 4 months ago

BTW: have a look at the letter R ...

KejPi commented 4 months ago

Yes, this is what I meant when calling them stupid. It is also in A letter.

andimik commented 2 months ago

I just saw that the transparent logos look good in the EPG window, as your background color is the same grey.

grafik

32x32 32x32

KejPi commented 2 months ago

Try to change to dark mode ;-)

KejPi commented 1 month ago

@andimik What about this? I could implement a possibility to set slideshow background from settings dialog. Would it resolve this issue?

KejPi commented 1 month ago

User can select any SLS background in settings, closing issue.