KejPi / AbracaDABra

Abraca DAB radio: DAB/DAB+ Software Defined Radio (SDR)
MIT License
65 stars 8 forks source link

Collapsing mux list highlights wrong service #77

Closed andimik closed 1 year ago

andimik commented 1 year ago

Bildschirmaufzeichnung vom 28.04.2023, 06:29:47.webm

This is just a cosmetic issue which I could reproduce only sometimes.

In this video I was clicking on the 1st service of each mux. After collapsing the mux list, a wrong service got highlighted on the right, which was never selected before. You still can listen to the service marked on the left of course.

KejPi commented 1 year ago

Can it be reproduced just selecting some (maybe first) service in the MUX and then keeping collapsing and uncollapsing the ensemble? Without selecting services from other ensembles before?

andimik commented 1 year ago

I'll try at home.

andimik commented 1 year ago

I found the root cause (drag&drop) but had no luck with the parameters in Qt-Designer in serviceTreeView

grafik

Here I've just held the left mouse button while moving ... (like drag&drop, but this not activated)

grafik

Bildschirmaufzeichnung vom 08.05.2023, 19:32:44.webm

KejPi commented 1 year ago

This is something I can finally reproduce. I agree that it behaves undesired way leading to selection of the service in service list that does not play but can this behavior explain the what you have observed before?

andimik commented 1 year ago

I guess it explains it. Because when you collapse the list, you are holding down the button.

KejPi commented 1 year ago

OK, it could be. I will try to find a way to fix this behavior.

KejPi commented 1 year ago

I have fixed "drag" issue in e7da6213dd28d5e545815ddffb60be3aa36aaa3a Please check, that the original issue is fixed too.

andimik commented 1 year ago

No, I cannot build it.

error: ‘qCFatal’ was not declared in this scope; did you mean ‘qFatal’?

When I change it to qFatal, I get

... mainwindow.cpp:391:16: error: cannot convert ‘const QLoggingCategory&()’ to ‘const char*’
andimik commented 1 year ago

Seems this is Qt 6.5

https://doc.qt.io/qt-6/qloggingcategory.html

This macro was introduced in Qt 6.5.

I have 6.2.4, see https://packages.ubuntu.com/jammy/qt6-base-dev

$ sudo apt list qt6-*
Auflistung… Fertig
qt6-3d-assimpsceneimport-plugin/jammy,now 6.2.4+dfsg-1 amd64  [installiert]
qt6-3d-defaultgeometryloader-plugin/jammy,now 6.2.4+dfsg-1 amd64  [installiert]
qt6-3d-dev/jammy,now 6.2.4+dfsg-1 amd64  [installiert]
qt6-3d-gltfsceneio-plugin/jammy,now 6.2.4+dfsg-1 amd64  [installiert]
qt6-3d-scene2d-plugin/jammy,now 6.2.4+dfsg-1 amd64  [installiert]
qt6-base-dev-tools/jammy-updates,now 6.2.4+dfsg-2ubuntu1.1 amd64  [installiert]
qt6-base-dev/jammy-updates,now 6.2.4+dfsg-2ubuntu1.1 amd64  [installiert]
qt6-base-private-dev/jammy-updates,now 6.2.4+dfsg-2ubuntu1.1 amd64  [installiert]
qt6-connectivity-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-declarative-dev-tools/jammy,now 6.2.4+dfsg-3ubuntu1 amd64  [installiert]
qt6-declarative-dev/jammy,now 6.2.4+dfsg-3ubuntu1 amd64  [installiert]
qt6-declarative-private-dev/jammy,now 6.2.4+dfsg-3ubuntu1 amd64  [installiert]
qt6-documentation-tools/jammy,now 6.2.4-1 amd64  [installiert]
qt6-gtk-platformtheme/jammy-updates,now 6.2.4+dfsg-2ubuntu1.1 amd64  [installiert]
qt6-image-formats-plugin-pdf/jammy,now 6.2.4+dfsg-6ubuntu1 amd64  [installiert]
qt6-image-formats-plugins/jammy,now 6.2.4-1 amd64  [installiert]
qt6-l10n-tools/jammy,now 6.2.4-1 amd64  [installiert]
qt6-multimedia-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-pdf-dev/jammy,now 6.2.4+dfsg-6ubuntu1 amd64  [installiert]
qt6-positioning-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-qmltooling-plugins/jammy,now 6.2.4+dfsg-3ubuntu1 amd64  [installiert]
qt6-qpa-plugins/jammy-updates,now 6.2.4+dfsg-2ubuntu1.1 amd64  [installiert]
qt6-quick3d-assetimporters-plugin/jammy,now 6.2.4-1 amd64  [installiert]
qt6-quick3d-dev-tools/jammy,now 6.2.4-1 amd64  [installiert]
qt6-quick3d-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-remoteobjects-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-scxml-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-shader-baker/jammy,now 6.2.4-2 amd64  [installiert]
qt6-tools-dev-tools/jammy,now 6.2.4-1 amd64  [installiert]
qt6-tools-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-tools-private-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-translations-l10n/jammy,jammy,now 6.2.4-1 all  [installiert]
qt6-virtualkeyboard-plugin/jammy,now 6.2.4+dfsg-1 amd64  [installiert]
qt6-wayland-dev-tools/jammy,now 6.2.4-1 amd64  [installiert]
qt6-wayland-dev/jammy,now 6.2.4-1 amd64  [installiert]
qt6-wayland/jammy,now 6.2.4-1 amd64  [installiert]
qt6-webengine-dev-tools/jammy,now 6.2.4+dfsg-6ubuntu1 amd64  [installiert]
qt6-webengine-dev/jammy,now 6.2.4+dfsg-6ubuntu1 amd64  [installiert]
qt6-webengine-private-dev/jammy,now 6.2.4+dfsg-6ubuntu1 amd64  [installiert]
qt6-webview-dev/jammy,now 6.2.4-2 amd64  [installiert]
qt6-webview-plugins/jammy,now 6.2.4-2 amd64  [installiert]
qt6-xdgdesktopportal-platformtheme/jammy-updates,now 6.2.4+dfsg-2ubuntu1.1 amd64  [installiert]
KejPi commented 1 year ago

Fixed in f29385e19ace4f4ddbf34cccd3a3131b94790158

andimik commented 1 year ago

Yes, looks good!

BTW: This is the updated German text AbracaDABra_de.zip

Hint: "Application log" and the three buttons on the bottom cannot be translated at the moment. I tried to lupdate but it does not work.

KejPi commented 1 year ago

Thanks for the translation. I will push update translation files update soon