Closed Linguardium closed 5 months ago
btw: I'm fully aware this Mixin can cause issues, which is why it isn't present in the 1.20.4 version anymore. I'm also planning to backport this change, but this also requires me to update the mods that have Konkrete as dependency, so it does not have very high priority right now.
The latest versions of Konkrete and FancyMenu (which triggered the NullPointer most of the time) are using this Mixin in a less aggressive way, so crashes related to that Mixin are very rarely happening in these versions.
https://github.com/Keksuccino/Konkrete/blob/309c477fec7f9d58dafdb9a63e22b16b93cb804a/src/main/java/de/keksuccino/konkrete/mixin/mixins/client/MixinScreenEvents.java#L20
https://mclo.gs/vQNMvfY
Should mark the mixin as not required and null check.
Should also mark tested fabric api versions in fabric.mod.json to prevent issues on versions where implementation may change since you call internal methods that may change even in minor patch releases of fapi