tracker: Split result handling from game creation

Kekun commented 8 years ago

Here are the commit message rules: https://wiki.gnome.org/Git/CommitMessages

"Summary line: Be sure to not exceed 72 characters. Try to not exceed 50"
"Description: Each line must not exceed 72 characters"

To these rules we add some others (that you couldn't know so no worries), here is a list out of my head:

in the description, try to fill as much as possible your lines (don't go to the line if the next word can fit),
don't go to the line after a sentence except of course if you cant add words after,
split paragraphs with two newlines (one empty line),
the first paragraph explains what the commit does from an objective point of view: the code change,
try to start sentences by the action performed, try to use the infinitive,
the second paragraph explains what the commit does from a subjective point of view: the behavior change,
don't talk about the what was before this commit, talk about what this commit does,
suffix methods and functions with parentheses (without the space) so when reading we know the name refers to an operation,
if the context isn't sufficient, be explicit with the types and the namespaces of the codepoints you cite,
write property names between single quotes and in kebab-case.

Here is what I would write for this commit:

tracker: Split result handling from game creation

Replace the each_game_for_query() method of TrackerGameSource and its
subtypes by the process_cursor() and foreach_game() methods.

This unties the number of tracker query results from the number of
produced games, avoiding useless errors in case of invalid query result
and allowing to build a game from multiple results, for example for
multi-disc games.

rgascons commented 8 years ago

I'm taking note of these extra guidelines, thanks! Applying the commit message you have suggested to the PR.

Kekun commented 8 years ago

I though we decided to use this as the commit message, am I wrong?

tracker: Split result handling from game creation

Replace the each_game_for_query() method of TrackerGameSource and its
subtypes by the process_cursor() and foreach_game() methods.

This unties the number of tracker query results from the number of
produced games, avoiding useless errors in case of invalid query result
and allowing to build a game from multiple results, for example for
multi-disc games.

Kekun commented 8 years ago

Besides that, it looks good.

rgascons commented 8 years ago

Closing with https://github.com/Kekun/gnome-games/commit/68bdb83d36ff48234b06eb8e8dbf121f75061048

Kekun / gnome-games

tracker: Split result handling from game creation #299