Closed meghprkh closed 8 years ago
Kekun
commented
8 years ago After these changes it should be quite good. We will have to remove some useless documentation and maybe also to add some new lines here and there to make the code more readable, but probably nothing more.
I'll review it once more once the last changes are applied, just in case, then we will be able to split this properly into logical pieces and to merge it! :)
Kekun
commented
8 years ago It looks like src/gamepad/dpad.vala is empty.
Kekun
commented
8 years ago BTW, how should we rename the namespace? What about:
Gpk to match Gdk and Gtk,GamepadKit to be more explicit and match WebKit,Gamepads for simplicity?
meghprkh
commented
8 years ago Closing this in favor of #306
Hello all. I wish to publicly apologize for the way I reacted. Though such behavior is unforgivable, I wish that you forgive me please. I will try to explain that why such a thing happened.
I am usually normal and while honestly I did get a little irritated in the past at the style guide commits, I never did react in such a way. But I have been changing the code since a long time (approx 2-3 weeks), and I also thought that I had to complete the GUI part before the GSoC deadline, so I got very "pissed off" because I taught I could not complete it then. It was due to the excessive pressure I thought I had on me due to the approaching deadline. I was feeling something like, when you are very near to completing a big step, but something just keeps making you slip backwards and yet you have many more steps to complete. However in today's afternoon chat with Adrien (on personal chat on IRC) (after I had put the comments but before they had been observed) I found out that I donot have to complete everything and thus I got relieved off a lot of pressure. He told me to take a break then. So I slept the entire afternoon and woke up with a clear mind and directly went to IRC to apologize. It is then that I saw my mail that I found out what had happened.
Yes almost daily (in between they didnot happen because he and then later me had some work to complete) and they are quite friendly. In fact even after I had insulted him so much he understood and didnot reply back with anger and just told me to take a break which has solved the issue to a great extent. I respect his patience.
I am extremely sorry for the way I reacted and want to be forgiven and promise that such a thing would never happen again.
P.S. I am not a native English speaker so please forgive some words which may not be very friendly or formal (Much of the content of this comment is from the apology mail I sent to the gnome soc admins, since I am really bad at rephrasing)