search

Keleo / DeductionTimeBundle

Configure certain activities as deduction time, resulting in negative durations for timesheets.
MIT License
6 stars 4 forks source link

Update DeductionTimeCalculator.php #9

Closed boekhorstb1 closed 10 months ago

boekhorstb1 commented 10 months ago

I tried to make it compatible with the interface, because I got this error:

#message: "Compile Error: Declaration of App\Timesheet\Calculator\BillableCalculator::calculate(App\Entity\Timesheet $record) must be compatible with App\Timesheet\CalculatorInterface::calculate(App\Entity\Timesheet $record, array $changeset)"
  #code: 0
  #file: "./src/Timesheet/Calculator/BillableCalculator.php"
  #line: 20
  -error: array:4 [
    "type" => 64
    "message" => "Declaration of App\Timesheet\Calculator\BillableCalculator::calculate(App\Entity\Timesheet $record) must be compatible with App\Timesheet\CalculatorInterface::calculate(App\Entity\Timesheet $record, array $changeset)"
    "file" => "/opt/kimai/src/Timesheet/Calculator/BillableCalculator.php"
    "line" => 20

followed installation setup from here: https://www.kimai.org/de/store/keleo-deduction-time-bundle.html

kevinpapst commented 10 months ago

Update your Kimai version or stick to the compatibility table

kevinpapst commented 10 months ago

Which means: thank you, but your PR makes no sense. Seems you are still using Kimai v 1.x - which is not compatible with latest main.

boekhorstb1 commented 10 months ago

Allright, I might have been confused by the instruction from here then @kevinpapst . It says this without mentioning the fact that one has to download a specific release from github:

<p dir="auto">This plugin is compatible with the following Kimai releases:</p>

Bundle version | Minimum Kimai version
-- | --
2.0 - 2.0.1 | 2.0.0
1.0 | 1.27.0

<p dir="auto"></p>

my version is 1.30.1 stable (Ayumi) currently., so I will give the release of 1.27 a try then, thanks

Im in the process of updating :) takes bit of time lets say