search

KelpFramework / kelp

A cross-version spigot framework to avoid boilerplate code and make your plugin compatible with multiple spigot versions easily
MIT License
54 stars 8 forks source link

[bugreport]: Harddepenencies on Kelp Apps not working #57

Open DSeeLP opened 3 years ago

DSeeLP commented 3 years ago

Describe the bug

I have a kelp app which depends on another Kelp App. The depent is registered as a hard dependency. Kelp fails to enable the App with the notice that the hard dependency can not be found.

What do we have to do to reproduce this bug?

Steps to reproduce the behavior:

  1. Create 2 Kelp Apps.
  2. Hard Depent one of them.
  3. You should now see in the console when you reload that the hard dependency can not be found.

What would you expect to happen?

It should load normally.

Provide the stack trace if possible (server logs, etc.). If you can, use the debug mode for that so that debug messages are logged as well

[18:17:48 INFO]: [Kelp] [APP] Detecting KelpApplications. [18:17:48 INFO]: [Kelp] [APP] Successfully loaded DatabaseProvider [18:17:48 WARN]: [Kelp] [APP] Dependency DatabaseProvider (required by CityLife) is unavailable [18:17:48 ERROR]: [Kelp] [APP] Failed to enable CityLife [18:17:48 INFO]: [Kelp] [APP] Loading application DatabaseProvider with version 1.0

Environment information

PXAV commented 3 years ago

Thank you for the bug report! I have to admit that the dependency feature has not been tested enough to spot such errors.

In MR 0.4 I have planned to give the application management system a complete overhaul (including things like a /kelp plugins or debug command, working dependencies, etc.), where this bug would be included as well then. Before that, 0.3.4 will release with entity implementations and things like #55 fixed.