search

KelpFramework / kelp

A cross-version spigot framework to avoid boilerplate code and make your plugin compatible with multiple spigot versions easily
MIT License
54 stars 8 forks source link

Implement KommonCommand into Kelp #60

Closed DSeeLP closed 3 years ago

DSeeLP commented 3 years ago

This pr adds support for my CommandSystem KommonCommand https://github.com/DSeeLP/Kommon/tree/development/command

Resolves #59

PXAV commented 3 years ago

Hi, the system looks nice, thanks for implementing it! But I am not sure whether external repositories are the best solution here. What if maintenance expires for KommonCommand? Maybe it would be better to directly integrate it into Kelp.

DSeeLP commented 3 years ago

Ok, should i move it to a namespace in kelp de.pxav or to de.dseelp

PXAV commented 3 years ago

That would be nice, thank you. The package name does not really matter I think.

The best solution would probably be to create a sub-package inside the command package, where the Kommon files go, and another sub-package, where the classes of the old command system go (such as CreateCommand and KelpCommand, etc.).

Classes used by both of the systems (such as KelpConsoleSender) remain in the main package.

But if you prefer you can also create a de.dseelp package of course.

DSeeLP commented 3 years ago

The de.dseelp package would be easier to update KommonCommand. So i think i use the de.dseelp package.

PXAV commented 3 years ago

Ah okay, I can relate, then use de.dseelp