search

Kelvin-Ben / mobile-version-portfolio

MIT License
5 stars 0 forks source link

Peer-to-Peer code review #3

Open Kelvin-Ben opened 2 years ago

Kelvin-Ben commented 2 years ago

Hello guys kindly check on this project I did and suggest for any changes that may be required.

Dinicharia commented 2 years ago

Good job!

asdt560 commented 2 years ago

It looks pretty good, I just have a few small nitpicks.

-Your textarea element may need a bit more padding at the top (notice the placeholder text being too close to the edge). -Your css list item in the cards looks slightly off center in its container.

Miliyonayalew commented 2 years ago

Good job 👍

I have minor comments please try to remove those toolbar icons, because by default mobile phones have that.

Kelvin-Ben commented 1 year ago

Hey @Miliyonayalew, I was very grateful for the suggestion. I realized I do not need to add them because they mobile default navbar. Thank you for noticing this on my project

Kelvin-Ben commented 1 year ago

Hey @asdt560, yeah for sure after you suggested I went through the form and realized something is off, I will definitely work on it. Thank you for such a great review :+1:

Kelvin-Ben commented 1 year ago

Thank you @Dinicharia, I appreciate your applause so much