KelvinAng95 / osmbonuspack

Automatically exported from code.google.com/p/osmbonuspack
0 stars 0 forks source link

fix for POI getThumbnailonThread #12

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hello, firstly, I've added osmdroid overlays and osmbonuspack to my 
experimental map-viewer. I had to modify the internals to work with my MapView 
and therefore added the sources to my project. If you have objections about 
author/copyright assignment please let me know. 

For the bug: the async loading of thumbnails doe not test whether the view 
passed to it still shows that poi (it could be reused for another when 
scrolling). I've modified it so that it checks in onPostExecute whether the 
thumbnails should be show on the view:

https://github.com/jeffdameth/VectorTileMap/blob/overlay/VectorTileMap/src/org/o
smdroid/location/POI.java

Best Regards

Original issue reported on code.google.com by hannes.j...@googlemail.com on 27 Oct 2012 at 12:06

GoogleCodeExporter commented 8 years ago
Hello Hannes, 

About the bug and the fix: thanks for that, I will try it as soon as I have a 
moment. 

About including the sources in your project: it's GPL, so no objection, as long 
as you keep mention of author (and if possible osmbonuspack package name - I 
didn't understood why you changed it to osmdroid everywhere). 
I would also be happy if you raise improvements/fixes, exactly as you did for 
this async loading. 

And (last but not least) you can put a comment about your project in the wiki 
page: http://code.google.com/p/osmbonuspack/wiki/ApplicationsUsingOSMBonusPack

Best regards

Original comment by mathieu....@gmail.com on 29 Oct 2012 at 7:10

GoogleCodeExporter commented 8 years ago
Fix integrated and commited. 

Original comment by mathieu....@gmail.com on 8 Nov 2012 at 9:22