Passwords display "True " if they will be deleted by the action of accessing them the last time

KelvinTegelaar / AzPwPush

11 stars 10 forks source link

Passwords display "True " if they will be deleted by the action of accessing them the last time #16

Open AshbyMike opened 3 years ago

AshbyMike commented 3 years ago

Steps to reproduce

Generate a password with a number of views greater than 0
Access the page every time until the "last" view before deletion - All OK
On the "last" view before deletion, "True " is appended to the password in the box. i.e. - "True VerdureGemmateHalesia)!=54"

Removing line number 32 in AzPwPush.psm1 resolves the issue

AshbyMike commented 3 years ago

scratch that, this seems to make deletions report abck as failing (even though they dont) AzPwPush.psm1 instead updated (in the Get-AzPassword function) to delete silently if($MaxViews -eq 1) { Delete-AzPassword -ID $ID | out-null }

KelvinTegelaar commented 3 years ago

checking this weekend and updating. :)

asweisman commented 3 years ago

Have you been able to take a look at this? I am having the same issue.

matstocks commented 3 years ago

hey @KelvinTegelaar This is still an issue if its something fixable?