search

KelvinTegelaar / AzPwPush

11 stars 11 forks source link

Security consideration - Password should not be in the URL #2

Closed itfranck closed 3 years ago

itfranck commented 3 years ago

Security wise, the form should do a Post and the URL should not contain the password in clear text ever, for 2 reason.

  1. Browser history Password is saved in clear text in the browser history. image

2 User (Code 18) If the user give the url from the address bar instead of the url in the form. (eg: I do sometimes that by mistake with Onetimesecret.com ), you end up giving the actual password in clear text and it will never burn.

Using Onetimesecret as a reference,

  1. The form is a Post
  2. The return url is an ID unrelated to the secret.
  3. There's a button click to view & burn the secret from the #2 location (So that even if you give the private url away, the password is burnt as soon as it is viewed anyway.
KelvinTegelaar commented 3 years ago

100% agreed. @itfranck. Expect it in the next iteration. :)

KelvinTegelaar commented 3 years ago

Fixed