KelvinTegelaar / CIPP

CIPP is a M365 multitenant management solution
https://cyberdrain.com / https://cipp.app
GNU Affero General Public License v3.0
783 stars 4.74k forks source link

[Feature Request]: New Scheduled Alert Option for Licensed Users without MFA #1661

Closed SIRKit-MDY closed 1 year ago

SIRKit-MDY commented 1 year ago

Description of the new feature - must be an in-depth explanation of the feature you want, reasoning why, and the added benefits for MSPs as a whole.

Currently the only alerts available are:

It would be very helpful to be able to alert on any licensed users without any form of MFA. Having something like a toggle filter for IsLicensed/IsEnabled or additional options for them to get the automated alerts would save a lot of time over having to manually pull/generate reports for every client every time as usually we don't necessarily care about the disabled/non-licensed users and having them included in every alert email when the base alert is enabled is very cumbersome and not as helpful as one would hope!

PowerShell commands you would normally use to achieve above request

No response

github-actions[bot] commented 1 year ago

Thank you for creating a feature request! Your current priority is set to "No Priority". No Priority Feature requests automatically get closed in two days if a contributor does not accept the FR.

If you are a sponsor you can request an upgrade of priority. To upgrade the priority type "I would like to upgrade the priority". If you want this feature to be integrated you can always do this yourself by checking out our contributions guide at https://cipp.app/docs/dev/. Contributors to the CIPP project reserve the right to close feature requests at will. If you'd like this feature request to be assigned to you, please comment "I would like to work on this please!".

BNWEIN commented 1 year ago

The current alert for users with MFA only looks users that are enabled as can be seen in the code on line 107 here: https://github.com/KelvinTegelaar/CIPP-API/blob/master/Scheduler_Alert/run.ps1

$users | Where-Object { $_.Usertype -eq 'Member' -and $_.BlockCredential -eq $false }

A user being licensed or not, should not be a blocker to enabling MFA. Any enabled user who can sign in should have MFA.

KelvinTegelaar commented 1 year ago

Next to just accepting FRs from sponsors at the moment, above is true too :)