search

KelvinTegelaar / CIPP

CIPP is a M365 multitenant management solution
https://cyberdrain.com / https://cipp.app
GNU Affero General Public License v3.0
755 stars 4.42k forks source link

Not Tested: Fixes the issue where user doesn't get removed from CA vacation due to user error #2602

Closed simislearning closed 6 days ago

simislearning commented 1 week ago
  1. values for data and time cannot be same for start and end time
  2. end time cannot be negative then start time or else user will not get remove from exclusions
KelvinTegelaar commented 6 days ago

No, sometimes people still want to use vacation mode with just an end date when manual adding has happened, and sometimes you want to remove the user instantly. Just because you don't see the use case doesn't mean there isn't one :)

simislearning commented 6 days ago

Thank you @KelvinTegelaar

I'm trying to understand the use case if you don't mind explaining it would be appreciated.

My main concern is human errors do occur and script doesn't complete successfully since there are human errors. I'm trying to understand how following would be okay in general and technically would that even work

  1. CA Vacation mode allows to have to start date for today and also allows end date from past therefore user never gets removed.
  2. CA Vacation mode allows allows same start end date time by default if user doesn't correctly pick time that's + then start time therefore user that is added to CA will never get removed.

sorry for being PITA about it i do appreciate your time.