search

KelvinTegelaar / CIPP

CIPP is a M365 multitenant management solution
https://cyberdrain.com / https://cipp.app
GNU Affero General Public License v3.0
775 stars 4.64k forks source link

"Set the destination email for user reported emails" standard not working as intended #2666

Closed kakaiwa closed 1 month ago

kakaiwa commented 1 month ago

Description

Currently, the Set the destination email for user reported emails standard does not work as expected. This is most likely because the standard currently only updates ReportSubmissionRule and not the ReportSubmissionPolicy.

https://learn.microsoft.com/en-us/defender-office-365/submissions-user-reported-messages-custom-mailbox

Expected result: the Add an exchange online mailbox to send reported messages to value for user submission policy should be the value configured in the standard Actual result: the Add an exchange online mailbox to send reported messages to value is empty even after the standard is ran. Log shows User Report Destination Email is already set to ...

Environment data

Sponsored
Front end version: 6.0.1
Back end version: 6.0.0
Tried Tenant Cache Clear: false
Tried Token Cache Clear: false
github-actions[bot] commented 1 month ago

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/ If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug."

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

kakaiwa commented 1 month ago

I would like to work on this please

KelvinTegelaar commented 1 month ago

My comment was about another standard entitely. Nevermind

kakaiwa commented 1 month ago

@KelvinTegelaar Thank you very much for checking. I might also consolidate the 2 standards into a single standard. I can see a situation where the Invoke-CIPPStandardUserReportDestinationEmail runs before Invoke-CIPPStandardUserSubmissions, causing an error because the policy doesn't exist yet.

KelvinTegelaar commented 1 month ago

implemented in dev, good job on your first pr! if you are in Discord tag me so I can mark you a contributor.