KelvinTegelaar / CIPP

CIPP is a M365 multitenant management solution
https://cyberdrain.com / https://cipp.app
GNU Affero General Public License v3.0
783 stars 4.74k forks source link

Missing "Tenant Mode" selector in SuperAdmin Settings #2767

Closed jdr8 closed 1 month ago

jdr8 commented 1 month ago

Description

In the SuperAdmin Settings tab of Application Settings, Tenant Mode does not allow you to select an option. 1) Click on "CIPP -> Application Settings" as a superadmin user 2) Navigate to the SuperAdmin Settings tab (visible when logged in as superadmin) 3) When loading completes - no option to select a tenant mode. image

Non-sponsored instance front end version 6.2.0 backend version 6.2.0 All caches cleared, different browser tested, "incognito" tested. Re-sign in tested.

Inspected elements, noticed nothing renders for a drop down or selection box, and no errors in console for this to not be appearing.

I can see the network response of ExecPartnerMode?Action=ListCurrent responds with TenantMode: "default", but there is no component rendering.

github-actions[bot] commented 1 month ago

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/ If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug."

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

jdr8 commented 1 month ago

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug

ccalbreath commented 1 month ago

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

lismorediocese commented 1 month ago

I am also having this issue

jdr8 commented 1 month ago

Looks like the following is missing from src/views/cipp/app-settings/SettingsSuperAdmin.jsx after line 68:

            <CRow>
              <CCol sm={12} md={12} className="mb-3">
                <p className="fw-lighter">Tenant Mode</p>
                <Form
                  onSubmit={onSubmit}
                  initialValues={partnerConfig.data}
                  render={({ handleSubmit }) => (
                    <>
                      {partnerConfig.isFetching && <CSpinner size="sm" className="me-2" />}
                      <CForm id="submitForm" onSubmit={handleSubmit}>
                        <RFFCFormRadio
                          name="TenantMode"
                          label="Multi Tenant - GDAP Mode"
                          value="default"
                        />
                        <RFFCFormRadio
                          name="TenantMode"
                          label="Multi Tenant - Add Partner Tenant"
                          value="PartnerTenantAvailable"
                        />
                        <RFFCFormRadio
                          name="TenantMode"
                          label="Single Tenant - Own Tenant Mode"
                          value="owntenant"
                        />
                      </CForm>
                    </>
                  )}
                />
                {webhookCreateResult.isSuccess && (
                  <CippCallout color="info" dismissible>
                    {webhookCreateResult?.data?.results}
                  </CippCallout>
                )}
              </CCol>
            </CRow>

This is now working for me after manually adding this back

KelvinTegelaar commented 1 month ago

Fixed in dev