Kemirdin / hyf-javascript3

0 stars 0 forks source link

hey Kem #1

Open fadikurdi opened 6 years ago

fadikurdi commented 6 years ago

hey Kem, 1- on line 75 we only have one film so you don't array but you will need it for stars since we have many stars. 2- in the constructor, you can have only title and director:

constructor(title, director) { this.title = title; this.director = director; this.stars = []; this.ratings = []; }

3- The push method only for arrays

Kemirdin commented 6 years ago

I really appreciate your feedback, I would fix it as soon as possible.

Kemirdin commented 6 years ago

you are totally right this is constructor(title, director) {

this.director = director;
this.title = title;
this.stars = [];
this.writer = [];
this.rating = [];
}  better than instead of  this constructor(title, director) { this.title = title; this.director = director; this.stars = []; this.ratings = []; } . thanks alot for your advice.