search

Kemirdin / hyf-javascript3

0 stars 0 forks source link

Updated Feedback Final Homework #5

Open remarcmij opened 6 years ago

remarcmij commented 6 years ago

Hi Kemirdin,

I'm pleasantly surprised by your latest homework. I must revise my earlier assessment of your progress. Well done!

Som minor comments:

  1. In your hyfListResponse function you use the createAndAppend function. However, in your uerDetailsResponse function (which has BTW still the spelling error I noted before) you don't use the createAndAppend function, but use separate creaetElement and appendChild method. This is inconsistent.

  2. I wouldn't show the contributors for every repo of a user. This is less relevant and you can quickly reach the GitHub API request limit of 60 per hour.

I have already posted my implementation of the homework. Please check that one for details how you can chain promises together and catch errors at the end.

Kemirdin commented 6 years ago

Dear Sensei, I really appreciate your feedback, I am also thank you for your feedback and guidance Sensei, my progress is because of your guidance.I will modify my code as you said.