Fix underlined title - Githubissues

farishan commented 2 years ago

Current behaviour: Ada additional height yang tidak perlu

Expected: Height sesuai yang dibutuhkan aja supaya gampang layouting sesuai Figma

rahmandihamzah commented 2 years ago

@farishan ini fix nya apa aja mas?

farishan commented 2 years ago

Sebelum fixing: https://github.com/Kempongan/does-next-app/blob/9ac9639e57b8ea5bf213d7199931c68bcc1fd2d5/components/UnderlinedTitle.js

Setelah fixing: https://github.com/Kempongan/does-next-app/blob/46628cb420f2dc66b8ff43ab3814c92d6e1a934a/components/UnderlinedTitle.js

Unnecessary height. Ini bikin unexpected spacing + susah pixel perfect karena harus ngitung
Underline tak ganti border supaya ga perlu render div baru
Tak tambahi microanimation, interaction state (hover), sama custom size props supaya lebih reusable

@rahmandihamzah

rahmandihamzah commented 2 years ago

Sip mas @farishan, makasih fix nya. Yang unexpected spacing ke miss pas develop, di issue ini udah ke fix, tapi perlu ada fix lagi karna ada expected design yg jadi nya gak kehandle

current:

expected:

Kempongan / does-next-app

Fix underlined title #33