search

KenEucker / biketag-vue

A vue app for the game of BikeTag played worldwide at biketag.org including the published biketag-vue component library
https://biketag.org
GNU Affero General Public License v3.0
22 stars 13 forks source link

Add a search #208

Open KenEucker opened 8 months ago

KenEucker commented 8 months ago

Is your feature request related to a problem? Please describe. Visitors to BikeTag.Org should be able to search both BikeTags and Players.

Describe the solution you'd like Maybe a search bar on the Players and BikeTags pages? (and Player)

wbholland commented 4 months ago

I'd be down to pick up this issue

KenEucker commented 4 months ago

@wbholland right on, let me know if you need any help getting things set up. You should be able to run the site locally and build a search without setting anything beyond the defaults.

wbholland commented 4 months ago

PR for just the player search part here https://github.com/KenEucker/biketag-vue/pull/251

KenEucker commented 4 months ago

@wbholland thank you for your contributions!

Are you thinking of adding a search to the BikeTags themselves? If so, I think I would be willing to help in the BikeTag API side of things by adding a search method for BikeTags. Let me know if you do want to add this and I would be happy to help on it,.

wbholland commented 4 months ago

It should be simple to do something very similar to how I implemented player search, i.e. filtering the data client-side, unless you prefer an API. If we go the client-side approach, I just am debating whether it's worth separating all the search functionality into a component that can be imported into both player and tag pages.