Improvements in Error Reporting and Logging
These changes involve additional console error and log statements in a few files (approve.ts, methods.ts, and index.ts). This helps in better tracking and debugging as it provides more detailed information on the system state during execution.
Particularly, it includes displaying nonAdminBiketagOpts and profile objects in the console, as well as printing out the data object and biketagAdminOpts variable in certain functions.
Changes in Property Prioritization
The PR modifies several instances in the code base(methods.ts, App.vue, index.ts) where the name property is now primarily fetched from profile.user_metadata.name. This may denote a shift in the structure or further normalization of the user profile data.
Variable and Function Adjustments
A better named variable: updatedPlayer has been renamed to updatedPlayerResponse in methods.ts, providing a clearer description of its contents.
Conditional logic updated: An 'if' condition check in methods.ts has been updated to check for failure scenarios (updatedPlayerResponse.success is false) instead of success scenarios.
setProfile function in index.ts accepts an additional token argument and modifies existing token variable usage.
Clean Up and Formatting
Unnecessary functions/logic removed: The startLoading function and a console log message have been removed from Player.vue and profile.ts respectively, optimizing and cleaning up the code.
Array manipulation: In Player.vue, the tagsForList computed property now uses a toReversed method on the tags array, suggesting a change in the order in which tags are being displayed.
Path changes: The changePage function in Player.vue now uses router.push with an updated path format, indicating potential updates in routing logic or page structure.
QueueFound.vue now uses val argument in the watch function instead of accessing getPlayerName.value directly.
Minor Version Upgrade
The version of the package has been updated to "3.2.5-2" (package-lock.json and package.json). This is likely an increment for a minor version update, following a few bug fixes or some improvements made in this PR.
PR Summary
Improvements in Error Reporting and Logging These changes involve additional console error and log statements in a few files (
approve.ts
,methods.ts
, andindex.ts
). This helps in better tracking and debugging as it provides more detailed information on the system state during execution.Particularly, it includes displaying
nonAdminBiketagOpts
andprofile
objects in the console, as well as printing out thedata
object andbiketagAdminOpts
variable in certain functions.Changes in Property Prioritization The PR modifies several instances in the code base(
methods.ts
,App.vue
,index.ts
) where thename
property is now primarily fetched fromprofile.user_metadata.name
. This may denote a shift in the structure or further normalization of the user profile data.Variable and Function Adjustments
updatedPlayer
has been renamed toupdatedPlayerResponse
inmethods.ts
, providing a clearer description of its contents.methods.ts
has been updated to check for failure scenarios (updatedPlayerResponse.success
is false) instead of success scenarios.setProfile
function inindex.ts
accepts an additionaltoken
argument and modifies existingtoken
variable usage.Clean Up and Formatting
startLoading
function and a console log message have been removed fromPlayer.vue
andprofile.ts
respectively, optimizing and cleaning up the code.Player.vue
, thetagsForList
computed property now uses atoReversed
method on thetags
array, suggesting a change in the order in which tags are being displayed.changePage
function inPlayer.vue
now usesrouter.push
with an updated path format, indicating potential updates in routing logic or page structure.QueueFound.vue
now usesval
argument in the watch function instead of accessinggetPlayerName.value
directly.Minor Version Upgrade The version of the package has been updated to "3.2.5-2" (
package-lock.json
andpackage.json
). This is likely an increment for a minor version update, following a few bug fixes or some improvements made in this PR.