KenKundert / emborg

Interactive command line interface to Borg Backup
GNU General Public License v3.0
94 stars 8 forks source link

Tests fail on v1.33 with borg 1.2.2 #66

Closed adhawkins closed 1 year ago

adhawkins commented 1 year ago

Seeing a number of tests fail under alpine when trying to package emborg v1.33. I suspect it's because you're not using borg 1.2.2 perhaps?

Failures all seem to follow the following pattern:

_________________________ test_emborg_with_configs[99] _________________________

initialize_configs = Info(
    borg_version=(1, 2, 2),
    fuse_is_missing=True,
)
name = 'acquaint'
args = '--quiet --config test8 borg list --prefix test8- --short @repo'
expected = {'exit_status': 0, 'output': 'test8-\\d\\d\\d\\d-\\d\\d-\\d\\dT\\d\\d:\\d\\d:\\d\\d'}
expected_type = 'regex', cmp_dirs = '', remove = '', dependencies = ''

    @parametrize(
        path = f'{tests_dir}/test-cases.nt',
        key = 'emborg with configs',
        schema = emborg_schema
    )
    def test_emborg_with_configs(
        initialize_configs,
        name, args, expected, expected_type, cmp_dirs, remove, dependencies
    ):
        skip_test_if_missing_dependencies(initialize_configs, dependencies)
        with cd(tests_dir):
            tester = EmborgTester(args, expected, expected_type, cmp_dirs, remove)
            passes = tester.run()
            if not passes:
                result = tester.get_result()
                expected = tester.get_expected()
>               assert result == expected, name
E               AssertionError: acquaint
E               assert {'exit_status...-25T12:03:24'} == {'exit_status...\d\\d:\\d\\d'}
E                 Omitting 1 identical items, use -vv to show
E                 Differing items:
E                 {'output': '\n        Warning: "--prefix" has been deprecated. Use "--glob-archives \'yourprefix*\'" (-a) instead.\n        test8-2022-10-25T12:03:24'} != {'output': 'test8-\\d\\d\\d\\d-\\d\\d-\\d\\dT\\d\\d:\\d\\d:\\d\\d'}
E                 Use -v to get more diff
KenKundert commented 1 year ago

Ugh. Your right, I was not testing with v1.2.2. I'm afraid this will take some time.

KenKundert commented 1 year ago

I have released a new version (1.34). All tests should pass now. Thanks for reporting this issue and for supporting Emborg.

adhawkins commented 1 year ago

Looks good, have submitted it to alpine.

KenKundert commented 1 year ago

Thanks Andy!