search

KendallDoesCoding / Choose-Your-Own-Adventure-Game

A simple Choose Your Own Adventure Game created using Python.
MIT License
15 stars 25 forks source link

[FEATURE REQUEST] Linux support #70

Open Naturalbornhippy opened 1 year ago

Naturalbornhippy commented 1 year ago

I was curios about the game and found out after running that is works only with windows. Maybe we can change this - python is supposed to give us cross platform support.

I will try to work on this task, maybe we can have a discussion about the solution and it would be good to have some windows tester, since i do not have a windows computer available.

I found already two spots, which have to be changed:

with those first two things the game is starting up, but still not functional. i will try to get more insights now. Any known other points already?

KendallDoesCoding commented 1 year ago

I was curios about the game and found out after running that is works only with windows. Maybe we can change this - python is supposed to give us cross platform support.

I will try to work on this task, maybe we can have a discussion about the solution and it would be good to have some windows tester, since i do not have a windows computer available.

I found already two spots, which have to be changed:

  • ctypes.windll.shell32.SetCurrentProcessExplicitAppUserModelID(myappid) <- is not working
  • music_player.py is using a wrong path. sound = pygame.mixer.Sound("Music/bliss.mp3") is only working because of windows. i would even say this is some kind of bug. it must be music instead

with those first two things the game is starting up, but still not functional. i will try to get more insights now. Any known other points already?

Can you share some screenshots?

Naturalbornhippy commented 1 year ago

grafik

i can type in the white box - when i debug it i can see that the player name is set. but than it does not continue

Naturalbornhippy commented 1 year ago

Short update, i think i fixed another bug while rendering the text. maybe i will create another PR for this (have to check first if this only happens for me) But the main problem seems to be that the font cant be rendered. the buttons seem to work now too: grafik

Edit: I have added some more debug message and the game it self works. i manged to get it running, it seems that i have a problem with this: fonts = pygame.sysfont.get_fonts() if emojis := [font for font in fonts if "emoji" in font]: self.font = pygame.font.SysFont(emojis[0], 60) self.button_font = pygame.font.SysFont(emojis[0], 40) self.small_font = pygame.font.SysFont(emojis[0], 30)

if i use a pygame.font.Font(None, ) than everything works, but without the emojis in the console.

Edit 2: It seems to be a problem only with "notocoloremoji" - other SysFonts work.

Naturalbornhippy commented 1 year ago

I have updated #71 with 3 changes now. With this changed it works out of the box on my ubuntu environment.

Would be great if someone can test it on other environments and make a windows check before merging :)