search

KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

Add cover image on the button of "Christmas Album by Ludwig" #150

Closed KendallDoesCoding closed 2 years ago

KendallDoesCoding commented 2 years ago

Fixes #16

netlify[bot] commented 2 years ago

✔️ Deploy Preview for mogulchristmas ready!

🔨 Explore the source changes: 5a49b26bbaa3024d16fa27ead0a73ef1fe39aee7

🔍 Inspect the deploy log: https://app.netlify.com/sites/mogulchristmas/deploys/61ebb48c3bec4d0007babf17

😎 Browse the preview: https://deploy-preview-150--mogulchristmas.netlify.app

KendallDoesCoding commented 2 years ago

This works but the buttons are coming up and then in a minute the songs load, @TechStudent11 can you fix this?

Right now, when the site opens the image comes, the buttons go up and then it comes down and only when it comes down it shows the songs.

See the preview here: https://deploy-preview-150--mogulchristmas.netlify.app/

TechStudent10 commented 2 years ago

This works but the buttons are coming up and then in a minute the songs load, @TechStudent11 can you fix this?

Right now, when the site opens the image comes, the buttons go up and then it comes down and only when it comes down it shows the songs.

See the preview here: https://deploy-preview-150--mogulchristmas.netlify.app/

When I tried, it was in a blink of the eye. It's flawless (ok maybe only the christmas trees because you have to scroll down).

KendallDoesCoding commented 2 years ago

This works but the buttons are coming up and then in a minute the songs load, @TechStudent11 can you fix this? Right now, when the site opens the image comes, the buttons go up and then it comes down and only when it comes down it shows the songs. See the preview here: https://deploy-preview-150--mogulchristmas.netlify.app/

When I tried, it was in a blink of the eye. It's flawless (ok maybe only the christmas trees because you have to scroll down).

I mean, ig it can be some kind of animation, but I prefer if it loads everything at once.

KendallDoesCoding commented 2 years ago

This works but the buttons are coming up and then in a minute the songs load, @TechStudent11 can you fix this? Right now, when the site opens the image comes, the buttons go up and then it comes down and only when it comes down it shows the songs. See the preview here: https://deploy-preview-150--mogulchristmas.netlify.app/

When I tried, it was in a blink of the eye. It's flawless (ok maybe only the christmas trees because you have to scroll down).

I mean, ig it can be some kind of animation, but I prefer if it loads everything at once.

So will you be able to make it so that everything loads at once, @TechStudent11 ?

TechStudent10 commented 2 years ago

Nah I don't think so. It's very quick.

KendallDoesCoding commented 2 years ago

This seems to be a issue with Netlify deploys for this project. I'll merge this and see if I occur the issue, if yes, I will revert changes.

KendallDoesCoding commented 2 years ago

Reverting changes, It seems to be a div issue. I will try to figure out the issue.

@TechStudent11 I know its a millisecond but thats kinda bothering me lol, so if you can try to find the issue that will be great too. Coz, I only adjusted the other pages page and this issue occured in #159 's deploy, idk why tbh. I like everything to load at once.

TechStudent10 commented 2 years ago

I know its a millisecond but thats kinda bothering me lol

Most people wouldn't mind.

TechStudent10 commented 2 years ago

If you want it to be quick, try using asynchronous coding. I'm not sure if this is possible in HTML.

KendallDoesCoding commented 2 years ago

I know its a millisecond but thats kinda bothering me lol

Most people wouldn't mind.

True

KendallDoesCoding commented 2 years ago

In my order PR, this issue happend only for same, I think it depends on your internet speed?

KendallDoesCoding commented 2 years ago

This works but the buttons are coming up and then in a minute the songs load, @TechStudent11 can you fix this? Right now, when the site opens the image comes, the buttons go up and then it comes down and only when it comes down it shows the songs.

See the preview here: https://deploy-preview-150--mogulchristmas.netlify.app/

@aliraza944 or @Bibhavshah Is this issue fixable?

KendallDoesCoding commented 2 years ago

Deleting branch in favor of #162