KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

Make a directory to thank contributors on the site. #192

Closed KendallDoesCoding closed 2 years ago

KendallDoesCoding commented 2 years ago

Make a directory to thank contributors on the site and link it via the README.md, dont list it on the main site though.

KendallDoesCoding commented 2 years ago

On second thought, I don't think, I'll add this for the simple reason that what should I inculde there, maximum everything I inculded in the thank you contributors section in commit e2af344

I was thinking of using a github api to tell what each contributor of project has done but I cant seem to find one, @TechStudent11 do you know of any api to do this?

TechStudent10 commented 2 years ago

https://docs.github.com/en/rest/reference/collaborators

KendallDoesCoding commented 2 years ago

https://docs.github.com/en/rest/reference/collaborators

This is using json right? Can you work on this?

TechStudent10 commented 2 years ago

https://docs.github.com/en/rest/reference/collaborators

This is using json right? Can you work on this?

So for the website right?

KendallDoesCoding commented 2 years ago

https://docs.github.com/en/rest/reference/collaborators

This is using json right? Can you work on this?

So for the website right?

yeah, you can make a directory called /collaborators, and do this there, I arent planning putting the directory on the main site. I will link it in README.md though

TechStudent10 commented 2 years ago

Hmmm, maybe in a few hours.

TechStudent10 commented 2 years ago

aka later today

KendallDoesCoding commented 2 years ago

Hmmm, maybe in a few hours.

Yeah ofc, take your time. This isnt something I need done on priority, I made a list of what I need done ASAP: https://github.com/users/KendallDoesCoding/projects/3

KendallDoesCoding commented 2 years ago

Adding the after-pr label now, as I though of another idea, #193 . I'll start work on that, and you can do work on the same PR or in a different one @TechStudent11 . I'm making the branch to work on #193 in the organization forked repo.

KendallDoesCoding commented 2 years ago

@TechStudent11 Please work on this issue in the following:

Directory - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/tree/work-on-193/credits/commits HTML - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/blob/work-on-193/credits/commits/index.html

Feel free to create a CSS, JS file in this directory if needed. I've called out this directory in the credits page which I'm working on so need you to do the stuff here, thanks.

KendallDoesCoding commented 2 years ago

@TechStudent11 Please work on this issue in the following:

Directory - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/tree/work-on-193/credits/commits HTML - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/blob/work-on-193/credits/commits/index.html

Feel free to create a CSS, JS file in this directory if needed. I've called out this directory in the credits page which I'm working on so need you to do the stuff here, thanks.

In the HTML I added a h1 saying coming soon, delete that when you start working on this.

KendallDoesCoding commented 2 years ago

@TechStudent11 Please work on this issue in the following: Directory - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/tree/work-on-193/credits/commits HTML - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/blob/work-on-193/credits/commits/index.html Feel free to create a CSS, JS file in this directory if needed. I've called out this directory in the credits page which I'm working on so need you to do the stuff here, thanks.

In the HTML I added a h1 saying coming soon, delete that when you start working on this.

@TechStudent11 Please start working on this today or tommrow, thanks.

TechStudent10 commented 2 years ago

@TechStudent11 Please work on this issue in the following: Directory - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/tree/work-on-193/credits/commits HTML - https://github.com/Kendall-Does-Coding-Websites/mogul-christmas/blob/work-on-193/credits/commits/index.html Feel free to create a CSS, JS file in this directory if needed. I've called out this directory in the credits page which I'm working on so need you to do the stuff here, thanks.

In the HTML I added a h1 saying coming soon, delete that when you start working on this.

@TechStudent11 Please start working on this today or tommrow, thanks.

Can’t today. My computer is in a bit of a state of “hiatus”. Can’t tomorrow because well I have other things I have to do (school, etc). Sorry. I work on it as soon as I am available. I’m actually typing this on my phone haha. By the way, what do you even want on this page? You want to thank the contributors, but how?

KendallDoesCoding commented 2 years ago

https://docs.github.com/en/rest/reference/collaborators

Ok, np. Do it as soon as your free. I thought your doing it using this right? https://docs.github.com/en/rest/reference/collaborators

KendallDoesCoding commented 2 years ago

For now, I'll embed https://github.com/KendallDoesCoding/mogul-christmas/graphs/contributors into the page I made in a recent PR #(194 I believe)

KendallDoesCoding commented 2 years ago

This was pretty much done in 70233057504d7ee9df59648ceaed1f840735dc68, although what I want for this is that it displays all the commits contributors made even in PR's etc, idk if that's possible though, so please let me know @TechStudent11 . But for now, it isn't really needed as I've displayed PR's contributors have worked on.

TechStudent10 commented 2 years ago

@KendallDoesCoding According to this answer on SO, yes it is possible: https://stackoverflow.com/a/58197588

But it would add extra bulk to the site and slow down load times.

KendallDoesCoding commented 2 years ago

@KendallDoesCoding According to this answer on SO, yes it is possible: https://stackoverflow.com/a/58197588

But it would add extra bulk to the site and slow down load times.

Ok, added talk: discussion, for now keeping this open, but it's most likely a no and we don't need to proceed on this, in that case.

KendallDoesCoding commented 2 years ago

This is kinda done in the credits directory, I can add the lines "Thanks to all our project contributors, your work and help is really appreciated."