KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

[FEATURE REQUEST] Random song button in You May Like directory #205

Closed KendallDoesCoding closed 2 years ago

KendallDoesCoding commented 2 years ago

A icon like attached screenshot below that if tapped will open any random url from the songs mentioned below... I think a easy way to do this is to provide a list of all the urls of the songs in the you may like directory using JS, that if tapped will pick one random url and open the youtube link in the new tab: image

Make the random profile, text Random Song when highlighted, ignore the background of the image, took this from another project, but this is just a example..

TechStudent10 commented 2 years ago

Hm. A random number generator could be made to do this. However I would wait for #203 and #189 to be completed.

KendallDoesCoding commented 2 years ago

Yeah maybe, I want a basic design now but once we do those issues, we can improve the design?

On Sat, 19 Feb 2022 at 02:47, TechStudent10 @.***> wrote:

Hm. A random number generator could be made to do this. However I would wait for #203 https://github.com/KendallDoesCoding/mogul-christmas/issues/203 and #189 https://github.com/KendallDoesCoding/mogul-christmas/issues/189 to be completed.

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/205#issuecomment-1045202171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTP3SRLUMPBWRZJD73TU32ZPPANCNFSM5OYY2KZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

TechStudent10 commented 2 years ago

It would be better to focus on the rewrite then add new features

KendallDoesCoding commented 2 years ago

True

On Sat, 19 Feb 2022 at 19:41, TechStudent10 @.***> wrote:

It would be better to focus on the rewrite then add new features

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/205#issuecomment-1046026237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTOJPYNXPP7LWKYXMIDU36QHZANCNFSM5OYY2KZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

KendallDoesCoding commented 2 years ago

I was actually planning on trying to finish all the issues first, then switching to Next.js because then we will get a idea of where everything needs to go @TechStudent11 , except for the really difficult ones, but I think this is easy to implement?

TechStudent10 commented 2 years ago

Alright, fine. I'll try. But first you need to create a new branch and put a button somewhere in the HTML, then I'll handle the rest of the JS.

KendallDoesCoding commented 2 years ago

Alright, fine. I'll try. But first you need to create a new branch and put a button somewhere in the HTML, then I'll handle the rest of the JS.

Ok will do!

KendallDoesCoding commented 2 years ago

YOO, Github Copilot literally did this all by itself... Working on touch ups now and will publish it to a branch.

image

KendallDoesCoding commented 2 years ago

@TechStudent11 Done.. Publishing to branch shortly.

KendallDoesCoding commented 2 years ago

@TechStudent11 Branch is here, should I make a PR so we get the deploy link?

https://github.com/KendallDoesCoding/mogul-christmas/tree/random-song

KendallDoesCoding commented 2 years ago

I don't wanna play song in browser (meaning i do but it will take extra js so let's keep it basic for now considering its not the main page on the website) so just I just want it to open any random url from the 11 songs in a new tab.

TechStudent10 commented 2 years ago

YOO, Github Copilot literally did this all by itself... Working on touch ups now and will publish it to a branch.

image

WAIT YOU HAVE COPILOT!?

I don't wanna play song in browser (meaning i do but it will take extra js so let's keep it basic for now considering its not the main page on the website) so just I just want it to open any random url from the 11 songs in a new tab.

Alright, will do.

KendallDoesCoding commented 2 years ago

Yeah, what's wrong with having copilot?

On Sun, 20 Feb 2022 at 02:16, TechStudent10 @.***> wrote:

YOO, Github Copilot literally did this all by itself... Working on touch ups now and will publish it to a branch.

[image: image] https://user-images.githubusercontent.com/84712013/154812178-22b00cc0-e158-443d-8442-28e4244265aa.png

WAIT YOU HAVE COPILOT!?

I don't wanna play song in browser (meaning i do but it will take extra js so let's keep it basic for now considering its not the main page on the website) so just I just want it to open any random url from the 11 songs in a new tab.

Alright, will do.

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/205#issuecomment-1046099668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTM6EPWANDJFW2DPK5DU376SDANCNFSM5OYY2KZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

KendallDoesCoding commented 2 years ago

@TechStudent11 Hope the button is fine.

TechStudent10 commented 2 years ago

Yeah, what's wrong with having copilot?

Nothing, just that I'm surprised that you were able to get into the beta. When it comes to betas on GitHub, it's an absolute nightmare. I tried joining the Codespaces beta and after more than well over half a year, it goes out of beta and now you have to pay to use it.

Wait is Copilot still in beta?

KendallDoesCoding commented 2 years ago

Well, for copilot, they're trying a system. If you join the beta, I don't remember how long it was, I think 1-2 months, you can download it and use it. Most youtubers, signed up when it was announced and they got access within 1-3 months.

I believe its still in BETA, yes.

On Sun, 20 Feb 2022 at 19:55, TechStudent10 @.***> wrote:

Yeah, what's wrong with having copilot?

Nothing, just that I'm surprised that you were able to get into the beta. When it comes to betas on GitHub, it's an absolute nightmare. I tried joining the Codespaces beta and after more than well over half a year, it goes out of beta and now you have to pay to use it.

Wait is Copilot still in beta?

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/205#issuecomment-1046249135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTMM663F45F442HOR7LU4D2UFANCNFSM5OYY2KZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

KendallDoesCoding commented 2 years ago

@TechStudent11 Please get to work on the JS part of this ASAP, I want this feature out by the 25th Feb.. Thanks a lot!

KendallDoesCoding commented 2 years ago

WOW. This is actually easy to get done... @TechStudent11 Can I work on this if you haven't already started working on it, that is. https://stackoverflow.com/questions/24509404/how-do-i-open-up-a-random-url-from-a-list-of-urls-in-a-new-time-each-time-it-is

KendallDoesCoding commented 2 years ago

@TechStudent11 Thanks for doing it... Did you follow the stack-overflow article?

EDIT: You used pretty much the same logic, but it's a little different :)

KendallDoesCoding commented 2 years ago

Before I make the release, just need to tweak it a bit, you added the js in the darkmode.js file and maybe make the button smaller, which I will work on doing later in the day...