KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

Random Song #207

Closed TechStudent10 closed 2 years ago

netlify[bot] commented 2 years ago

✔️ Deploy Preview for mogulchristmas ready!

🔨 Explore the source changes: 96415474e83a1f194c4d52f60fc79e2094f7f319

🔍 Inspect the deploy log: https://app.netlify.com/sites/mogulchristmas/deploys/621948c2fb4c76000786242c

😎 Browse the preview: https://deploy-preview-207--mogulchristmas.netlify.app

KendallDoesCoding commented 2 years ago

@TechStudent11 Opening this PR on git just to style the button up a bit.

KendallDoesCoding commented 2 years ago

@TechStudent11 Opening this PR on git just to style the button up a bit.

There ya go.. Please have a look and let me know your feedback TechStudent11.

TechStudent10 commented 2 years ago

I would remove the outline from the button

image

KendallDoesCoding commented 2 years ago

I would remove the outline from the button

image

Ok will work on that in a min.

KendallDoesCoding commented 2 years ago

I would remove the outline from the button image

Ok will work on that in a min.

@TechStudent11 Done in commit 0deb568.. Hope this is what you wanted!

KendallDoesCoding commented 2 years ago

I would remove the outline from the button image

Ok will work on that in a min.

@TechStudent11 Done in commit 0deb568.. Hope this is what you wanted!

The issue is, now if I click the button it doesn't show anything when tapped, but maybe this can be fixed when the JS is done?

KendallDoesCoding commented 2 years ago

Made the button bigger, but idk how to make the font awesome icon bigger, added a id to the icon though to call it out in css later.

TechStudent10 commented 2 years ago

looks good. you can add cursor: pointer; to your css to get the click cursor (or whatever) again

KendallDoesCoding commented 2 years ago

looks good. you can add cursor: pointer; to your css to get the click cursor (or whatever) again

Thanks. Will try doing it in a bit!.

KendallDoesCoding commented 2 years ago

looks good. you can add cursor: pointer; to your css to get the click cursor (or whatever) again

Thanks. Will try doing it in a bit!.

That kinda worked, before it used to reload the button when clicked, now it doesn't really do that, but I think it's fine.. We'll see how it works once the JS is done and I will update if needed. It won't make a difference, coz when clicked = opens song in new tab, so if it opens song in new tab, it's not really a worry as of such.

KendallDoesCoding commented 2 years ago

@TechStudent11 Please have a look now after Github Copilot's suggestions made to the code.

KendallDoesCoding commented 2 years ago

Tbh, I don't really like the icon near the button now, I think the button looks better alone. What do yall think about it @TechStudent11 @sc0rp10n-py ?

KendallDoesCoding commented 2 years ago

@TechStudent11 When you make the JS I also want it that when the button is clicked, to console log "Random song has open in a new tab" Maybe the "random song" can have the name of the song it chose, if possible too. Thanks.

KendallDoesCoding commented 2 years ago

@TechStudent11 Please let me know when you can begin work on the JS of this.. Thanks :)

TechStudent10 commented 2 years ago

That took some work but it works now

KendallDoesCoding commented 2 years ago

That took some work but it works now

Yup it takes work to add all the songs urls in lol, but from now coz this system is in play. When I add a new song, I'll add it here too :D.

KendallDoesCoding commented 2 years ago

I usually squah and merge depending on the PR, but no worries!

KendallDoesCoding commented 2 years ago

@all-contributors, please add @TechStudent11 to the doc for their contribution

KendallDoesCoding commented 2 years ago

@all-contributors, please add @TechStudent11 to the doc for their contribution

Sorry for the duplicate ping.

KendallDoesCoding commented 2 years ago

@all-contributors please add @JeffBucherDev to the doc for their contribution

allcontributors[bot] commented 2 years ago

@KendallDoesCoding

I've put up a pull request to add @JeffBucherDev! :tada:

KendallDoesCoding commented 2 years ago

@all-contributors please add @TechStudent11 to the doc for their contribution

allcontributors[bot] commented 2 years ago

@KendallDoesCoding

I've put up a pull request to add @TechStudent11! :tada: