[BUG] Background not displaying on phone/small screen size.

[KendallDoesCoding]

The background isn't displaying on phones or on a small screen size for some reason, for both lightmode and darkmode on the main page, entire lyrics directory, you may like page. idk what the issue is.

[KendallDoesCoding]

This issue has only come in too place since we made a Christmas theme background, v16.5.0.

[KendallDoesCoding]

@TechStudent11 Can you help figure out the issue on this?

[samyberkane04]

@TechStudent11 can i work on this issue please ?

[samyberkane04]

@TechStudent11 there is no background :

[KendallDoesCoding]

@TechStudent11 can i work on this issue please ?

yeah ofc.

[KendallDoesCoding]

@TechStudent11 there is no background :

There is?

[KendallDoesCoding]

@samyberkane04 There is an issue with your end with the background, can you record a screen share video opening, https://kendalldoescoding.gq/mogulchristmas so I can try to debug the issue, the background works fine for me on both localhost and on the website. Maybe it didn't load properly or your internet had some issue, please try reloading the webpage.

[KendallDoesCoding]

@samyberkane04 Useful info: The background stops showing at dimensions: 621 x 666... It shows till then.

[samyberkane04]

@KendallDoesCoding

that's what I did :

[KendallDoesCoding]

@KendallDoesCoding

that's what I did :

Well, if it works for you then no issues, but for me it doesn't render properly on mobile/small screen size, idk why. I'll figure it out.

[KendallDoesCoding]

@samyberkane04 The background works for 621 x 666, but stops working at 620 x 666.

[samyberkane04]

@KendallDoesCoding I changed the code to get this result, when you change your window size(small screen size) the bakground don't stops working.

[KendallDoesCoding]

@KendallDoesCoding I changed the code to get this result, when you change your window size(small screen size) the bakground don't stops working.

Oh ok, please make a PR, if you need help feel free to ask :).

[samyberkane04]

@KendallDoesCoding

I did an other PR, I think I solved this issue.

[KendallDoesCoding]

@KendallDoesCoding

I did an other PR, I think I solved this issue.

Thanks but the deploy preview aren't working for some reason, check my comments in #264!

[samyberkane04]

@KendallDoesCoding ok I will do an other PR .

[KendallDoesCoding]

Thanks a lot @samyberkane04 for your help.

[KendallDoesCoding]

@samyberkane04 The first button is 2 lines instead of one line, please fix.

[KendallDoesCoding]

https://6245e49cb0b3d7000836b837--mogulchristmas.netlify.app/

[KendallDoesCoding]

@samyberkane04 The first button is 2 lines instead of one line, please fix.

I've reverted the changes I merged, please fix this.

[samyberkane04]

@KendallDoesCoding

ok I will change it.

[samyberkane04]

@KendallDoesCoding

i did the changes, but i can't always do a PR.

[KendallDoesCoding]

thanks

On Thu, 31 Mar 2022 at 23:26, samyberkane04 @.***> wrote:

@KendallDoesCoding https://github.com/KendallDoesCoding

i did the changes.

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/259#issuecomment-1084927913, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTJIVLVIJ3MH4VRQ7FDVCXRNZANCNFSM5R6ALUFA . You are receiving this because you were mentioned.Message ID: @.***>

[KendallDoesCoding]

@samyberkane04 Reverting your changes as I believe it messed up a lot of stuff in the directories.

[samyberkane04]

@KendallDoesCoding

I think the code that I do it's works for this issue . (it's works for both modes ) I don't understand where is the problem ?

[KendallDoesCoding]

@KendallDoesCoding

I think the code that I do it's works for this issue . (it's works for both modes ) I don't understand where is the problem ?

Yeah but the lyrics direcotry is messed up, even lud socials.

[KendallDoesCoding]

I added this a long time back, that's the issue:

@media screen and (max-width: 620px) {
  body {
    background-image: none;
  }
}

[KendallDoesCoding]

thanks

On Thu, 31 Mar 2022 at 21:46, samyberkane04 @.***> wrote:

@KendallDoesCoding https://github.com/KendallDoesCoding ok I will do an other PR .

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/259#issuecomment-1084802183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTL5RNSVPBAGYGRAFOTVCXFWHANCNFSM5R6ALUFA . You are receiving this because you were mentioned.Message ID: @.***>