search

KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

[YOUTUBE API] Standard volume for songs played using the website #311

Closed KendallDoesCoding closed 1 year ago

KendallDoesCoding commented 2 years ago

Currently, the sound of the video/embed depends on the LAST watched YouTube video volume, however, that could've been on mute, then as mentioned in the README.md, the site will not be able to play the music - "Please ensure that the last YouTube video you watched wasn't on mute, otherwise the songs will not play, and the autoplay for the lyrics' directory will automatically be set on mute too."

So, I was researching and it seems we can add some JavaScript (Youtube API) that the volume of every embed will be standard set amount by us (i hope this is how it works, i'm unsure) we can set a standard volume.

Set the standard volume to 50/50%

Reference: https://developers.google.com/youtube/iframe_api_reference#setVolume

@TechStudent10 can you do this pls?

TechStudent10 commented 2 years ago

This seems simple. Why not do it yourself?

KendallDoesCoding commented 2 years ago

This seems simple. Why not do it yourself?

I'm not a pro at JS and will surely mess it up 🤣 . Plus, I put the EddieHub-good-first-issue label so somebody good at JS and new to open-source can contribute and learn open-source!!

TechStudent10 commented 2 years ago

This seems simple. Why not do it yourself?

I'm not a pro at JS and will surely mess it up 🤣 . Plus, I put the EddieHub-good-first-issue label so somebody good at JS and new to open-source can contribute and learn open-source!!

Then learn. Also I'm definitely not saying this because I'm lazy, no, no, no.

KendallDoesCoding commented 2 years ago

This seems simple. Why not do it yourself?

I'm not a pro at JS and will surely mess it up 🤣 . Plus, I put the EddieHub-good-first-issue label so somebody good at JS and new to open-source can contribute and learn open-source!!

Then learn. Also I'm definitely not saying this because I'm lazy, no, no, no.

ok.

KlausMikhaelson commented 2 years ago

Hey @KendallDoesCoding I have worked with the youtube api a lot so ig I will be able to do it with ease can you assign this to me ?

KendallDoesCoding commented 2 years ago

Sure!

On Wed, 14 Sep 2022, 2:52 am KlausMikhaelson, @.***> wrote:

Hey @KendallDoesCoding https://github.com/KendallDoesCoding I have worked with the youtube api a lot so ig I will be able to do it with ease can you assign this to me ?

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/311#issuecomment-1245967239, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTNOSRPSG2G7RPICUQDV6DWB3ANCNFSM57QMS6NQ . You are receiving this because you were mentioned.Message ID: @.***>

KendallDoesCoding commented 2 years ago

@KlausMikhaelson any update?

KlausMikhaelson commented 2 years ago

Sorry I forgot to see that this one is assigned to me, currently working on another issue of making the site responsive so will move on to this as soon as I am done, last to last will probably completely it till tomorrow

KendallDoesCoding commented 2 years ago

Sorry I forgot to see that this one is assigned to me, currently working on another issue of making the site responsive so will move on to this as soon as I am done, last to last will probably completely it till tomorrow

Sure! Let me know if you need any help.

KlausMikhaelson commented 2 years ago

Hey sorry again I just came back home after a month of hectic travelling I am working on it right now and create the pr in few hrs

KendallDoesCoding commented 2 years ago

Yeah bro, sure. I understand!

On Fri, 14 Oct 2022, 11:57 am Satyam, @.***> wrote:

Hey sorry again I just came back home after a month of hectic travelling I am working on it right now and create the pr in few hrs

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/311#issuecomment-1278542866, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTLVTO6D7YS5WB5LRJTWDD4NTANCNFSM57QMS6NQ . You are receiving this because you were mentioned.Message ID: @.***>

KlausMikhaelson commented 2 years ago

I figured out how to do that when we have that big script of embeded api but still figuring out how I can implement it in the iframe

KendallDoesCoding commented 2 years ago

Good to hear!

On Fri, 14 Oct 2022 at 19:02, Satyam @.***> wrote:

I figured out how to do that when we have that big script of embeded api but still figuring out how I can implement it in the iframe

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/issues/311#issuecomment-1279016211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTOUVCFM4Q4CNWX7LSLWDFOIHANCNFSM57QMS6NQ . You are receiving this because you were mentioned.Message ID: @.***>